Created new Mutator for strtoupper function #535
Conversation
…ion#523) * Restrict installation with broken versions of symfony/console Also ignore bogus PHPStan warnings. * Update TestFrameworkFinder to always look for a .bat first. (infection#506) * Update TestFrameworkFinder to always look for a .bat first. Fixes infection#503 * Phpunit_Bat_Wrapper: add cwd to path just for this test * Phpunit_Bat_Wrapper: it does not matter if Infection succeeds, only it must find phpunit.bat
| <<<'PHP' | ||
| <?php | ||
|
|
||
| function array_flip($text) |
There was a problem hiding this comment.
it should be function strtoupper
There was a problem hiding this comment.
@borNfreee @zf2timo
Ha, made the same mistake a couple of times! 🤓
| PHP | ||
| ]; | ||
|
|
||
| yield 'It does not mutate functions named array_flip' => [ |
| <<<'PHP' | ||
| <?php | ||
|
|
||
| $a = strtoupper(['A', 1, 'C']); |
There was a problem hiding this comment.
I suggest using string, not an array for all these examples, because strtoupper works with strings ;)
| PHP | ||
| ]; | ||
|
|
||
| yield 'It mutates correctly when array_flip is wrongly capitalized' => [ |
| PHP | ||
| ]; | ||
|
|
||
| yield 'It mutates correctly when array_flip uses another function as input' => [ |
* Enhancement: Enable no_superfluous_phpdoc_tags fixer * Fix: Run php-cs-fixer * Fix: Remove useless DocBlocks
…ection#519) * Run project's tests in a random order for InitialTestRun process if it's possible * Run project's tests in a random order for PHPUnit 7.2+ * Remove config.platform.php=7.0 from e2e tests. Add PHPUnit's cache file to .gitignore * Do not update executionOrder if it is set in phpunit.xml * Improve exception message to inform users about how to not allow Infection randomize tests * Add e2e test to ensure Infection does not try to randomize tests execution order when `phpunit.xml` contains `executeOrder="XXX"`
There was a problem hiding this comment.
Also, this needs to be rebased to use a new approach with yield, see
for an example.
@zf2timo are you going to finish this one or can we take over it? I'm planning a release soon, want to get this merged before it is published
# Conflicts: # composer.lock # devTools/phpstan-src.neon
* Enhancement: Assert that mutators in mutator profile constants are sorted by name * Fix: Keep mutators in mutator profiles sorted by name
|
@borNfreee Sorry for the delay. I was an a small vacation. |
…ion into feature/unwrap-strtoupper
The function name being variable caused issues in other mutators before So we want to make sure it doesn't happen for the unwrap mutators
…ion into feature/unwrap-strtoupper
|
Ha, looks like something went wrong with the rebase. |
|
@localheinz yes, this looks bad. @borNfreee maybe I create a new PR? |
|
Yeah, let's do it |
|
Closed by #551 |
This PR:
UnwrapStrToUpperas suggested in New @unwrap mutators ideas #514