Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new Mutator for strtoupper function #535

Closed
wants to merge 28 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ccffd49
Restrict installation with broken versions of symfony/console (#523)
sanmai Oct 30, 2018
e5ece66
Created new Mutator for strtoupper function
zf2timo Oct 31, 2018
2439066
Enhancement: Enable no_superfluous_phpdoc_tags fixer (#525)
localheinz Nov 1, 2018
a5491a8
Enhancement: Fail with a better assertion message (#538)
localheinz Nov 1, 2018
b89ecc4
Enhancement: Implement UnwrapStrRepeat mutator (#539)
localheinz Nov 2, 2018
66272d0
Run project's tests in a random order for InitialTestRun process (#519)
maks-rafalko Nov 2, 2018
aaa244c
Enhancement: Implement UnwrapArrayReduce mutator (#533)
localheinz Nov 2, 2018
21e9bff
Fix: Add UnwrapStrRepeat to Unwrap mutator profile
localheinz Nov 2, 2018
b7a0540
Add test to ensure all mutators are assigned to at least one profile
maks-rafalko Nov 3, 2018
c24ebd3
Enhancement: Implement UnwrapArrayReplace mutator
localheinz Oct 31, 2018
0ba9520
Enhancement: Use generic approach
localheinz Nov 1, 2018
a6ab3a5
Merge branch '0.10'
maks-rafalko Nov 3, 2018
fed05b8
Update composer.lock after merge
maks-rafalko Nov 3, 2018
a76e43f
Enhancement: Implement UnwrapStrtolower mutator
localheinz Oct 31, 2018
2debcd3
Fix: Keep mutators in mutator profiles sorted by name (#541)
localheinz Nov 4, 2018
d389522
Enhancement: Implement UnwrapArrayIntersect mutator (#543)
localheinz Nov 4, 2018
353d53a
Enhancement: Implement UnwrapArrayMerge mutator (#542)
localheinz Nov 4, 2018
102aa26
Created new Mutator for strtoupper function
zf2timo Oct 31, 2018
b74f77f
Fixed copy and paste errors
zf2timo Nov 4, 2018
ff07af5
Merge branch 'feature/unwrap-strtoupper' of github.com:zf2timo/infect…
zf2timo Nov 4, 2018
1cf909c
Changed UnwrapStrToUpper::getParameterIndex to new interface
zf2timo Nov 4, 2018
e85f05f
Fix: Use plural for method name as it returns a generator (#546)
localheinz Nov 5, 2018
c696d27
Fix variable names in mutators (#549)
BackEndTea Nov 5, 2018
36e1894
Created new Mutator for strtoupper function
zf2timo Oct 31, 2018
528c6ba
Fixed copy and paste errors
zf2timo Nov 4, 2018
03b30e0
Changed UnwrapStrToUpper::getParameterIndex to new interface
zf2timo Nov 4, 2018
1d97992
Rebased onto upstream/master
zf2timo Nov 5, 2018
711b6ab
Merge branch 'feature/unwrap-strtoupper' of github.com:zf2timo/infect…
zf2timo Nov 5, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 52 additions & 0 deletions src/Mutator/Unwrap/UnwrapStrToUpper.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
<?php
/**
* This code is licensed under the BSD 3-Clause License.
*
* Copyright (c) 2017-2018, Maks Rafalko
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* * Redistributions of source code must retain the above copyright notice, this
* list of conditions and the following disclaimer.
*
* * Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* * Neither the name of the copyright holder nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

declare(strict_types=1);

namespace Infection\Mutator\Unwrap;

/**
* @internal
*/
final class UnwrapStrToUpper extends AbstractUnwrapMutator
{
protected function getFunctionName(): string
{
return 'strtoupper';
}

protected function getParameterIndex(): int
{
return 0;
}
}
2 changes: 2 additions & 0 deletions src/Mutator/Util/MutatorProfile.php
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ final class MutatorProfile
Mutator\Unwrap\UnwrapArrayFlip::class,
Mutator\Unwrap\UnwrapArrayMap::class,
Mutator\Unwrap\UnwrapArrayReverse::class,
Mutator\Unwrap\UnwrapStrToUpper::class,
];

public const DEFAULT = [
Expand Down Expand Up @@ -318,5 +319,6 @@ final class MutatorProfile
'UnwrapArrayFlip' => Mutator\Unwrap\UnwrapArrayFlip::class,
'UnwrapArrayMap' => Mutator\Unwrap\UnwrapArrayMap::class,
'UnwrapArrayReverse' => Mutator\Unwrap\UnwrapArrayReverse::class,
'UnwrapStrToUpper' => Mutator\Unwrap\UnwrapStrToUpper::class,
];
}
177 changes: 177 additions & 0 deletions tests/Mutator/Unwrap/UnwrapStrToUpperTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,177 @@
<?php
/**
* This code is licensed under the BSD 3-Clause License.
*
* Copyright (c) 2017-2018, Maks Rafalko
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* * Redistributions of source code must retain the above copyright notice, this
* list of conditions and the following disclaimer.
*
* * Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* * Neither the name of the copyright holder nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

declare(strict_types=1);

namespace Infection\Tests\Mutator\Unwrap;

use Infection\Tests\Mutator\AbstractMutatorTestCase;

/**
* @internal
*/
final class UnwrapStrToUpperTest extends AbstractMutatorTestCase
{
/**
* @dataProvider provideMutationCases
*/
public function test_mutator($input, $expected = null): void
{
$this->doTest($input, $expected);
}

public function provideMutationCases(): \Generator
{
yield 'It mutates correctly when provided with an array' => [
<<<'PHP'
<?php

$a = strtoupper(['A', 1, 'C']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using string, not an array for all these examples, because strtoupper works with strings ;)

PHP
,
<<<'PHP'
<?php

$a = ['A', 1, 'C'];
PHP
];

yield 'It mutates correctly when provided with a constant' => [
<<<'PHP'
<?php

$a = strtoupper(\Class_With_Const::Const);
PHP
,
<<<'PHP'
<?php

$a = \Class_With_Const::Const;
PHP
];

yield 'It mutates correctly when a backslash is in front of array_flip' => [
<<<'PHP'
<?php

$a = \strtoupper(['A', 1, 'C']);
PHP
,
<<<'PHP'
<?php

$a = ['A', 1, 'C'];
PHP
];

yield 'It does not mutate other array_ calls' => [
<<<'PHP'
<?php

$a = array_map('strtoupper', ['A', 'B', 'C']);
PHP
];

yield 'It does not mutate functions named array_flip' => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array_flip -> strtoupper

<<<'PHP'
<?php

function array_flip($text)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be function strtoupper

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borNfreee @zf2timo

Ha, made the same mistake a couple of times! 🤓

{
}
PHP
];

yield 'It mutates correctly within if statements' => [
<<<'PHP'
<?php

$a = ['A', 1, 'C'];
if (strtoupper($a) === $a) {
return true;
}
PHP
,
<<<'PHP'
<?php

$a = ['A', 1, 'C'];
if ($a === $a) {
return true;
}
PHP
];

yield 'It mutates correctly when array_flip is wrongly capitalized' => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array_flip -> strtoupper

<<<'PHP'
<?php

$a = StrToUpper(['A', 1, 'C']);
PHP
,
<<<'PHP'
<?php

$a = ['A', 1, 'C'];
PHP
];

yield 'It mutates correctly when array_flip uses another function as input' => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array_flip -> strtoupper

<<<'PHP'
<?php

$a = strtoupper($foo->bar());
PHP
,
<<<'PHP'
<?php

$a = $foo->bar();
PHP
];

yield 'It mutates correctly when provided with a more complex situation' => [
<<<'PHP'
<?php

$a = array_map('strtoupper', strtoupper(['A', 1, 'C']));
PHP
,
<<<'PHP'
<?php

$a = array_map('strtoupper', ['A', 1, 'C']);
PHP
];
}
}