Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new UnwrapStrToUpper mutator #551

Closed

Conversation

zf2timo
Copy link
Contributor

@zf2timo zf2timo commented Nov 5, 2018

This PR:

Replaces #535

@maks-rafalko maks-rafalko added this to the 0.11.0 milestone Nov 5, 2018
@maks-rafalko
Copy link
Member

Fixed code style

you can run make cs-fix to automatically fix all CS issues

PHP
];

yield 'It does not mutate other array_ calls' => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I think this test case doesn't apply - can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could be changed to "It does not mutate other strto calls"? Or adds this still no value?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could be changed to "It does not mutate other strto calls"?

👍

sanmai and others added 12 commits November 7, 2018 12:40
* Do not mutate interfaces

Interfaces are always uncovered, therefore it makes no sense to mutate anything on them.

Fixes infection#547

* Do not mutate interfaces

Interfaces are always uncovered, therefore it makes no sense to mutate anything on them.

Fixes infection#547
…nstall dependencies (infection#552)

Packagist is a free service and is not 100% reliable as one may guess, but since we run multiple same tests at once in different environments, if we occasionally skip a test for reasons we can't control, it should do no harm.
…imo/infection into feature/strtoupper-mutator-2edition
@zf2timo
Copy link
Contributor Author

zf2timo commented Nov 7, 2018

I don't get it. There is again something wrong.
I made theses steps to rebase onto the latest master:

$  git checkout master
$  git pull upstream master
$  git checkout feature/strtoupper-mutator-2edition
$  git rebase master
$  git push origin feature/strtoupper-mutator-2edition # <-- this one was blocked
$  git pull origin feature/strtoupper-mutator-2edition # <-- here I had to resolve a merge conflict in the UnwrapStrToUpperTest 
$  git commit
$  git push origin feature/strtoupper-mutator-2edition

@sanmai
Copy link
Member

sanmai commented Nov 7, 2018

Try making a new branch out of current master, then ‘git cherry-pick’ your commits.

@zf2timo
Copy link
Contributor Author

zf2timo commented Nov 8, 2018

I will try it this evening.
But my executed commands where correct to rebase?

@localheinz
Copy link
Member

@zf2timo

Here is how I usually keep a branch updated:

$ git checkout master
$ git fetch upstream
$ git merge upstream/master
$ git push origin master
$ git checkout my-branch
$ git rebase master

Sometimes I then need to resolve conflicts.

$ git push -f origin my-branch

@zf2timo zf2timo mentioned this pull request Nov 8, 2018
3 tasks
@maks-rafalko
Copy link
Member

superseded by #559

@zf2timo zf2timo deleted the feature/strtoupper-mutator-2edition branch November 12, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants