Enhancement: Use generic approach

infection · Nov 3, 2018 · 0ba9520 · 0ba9520
1 parent c24ebd3
commit 0ba9520
Show file tree

Hide file tree

Showing 8 changed files with 37 additions and 36 deletions.
diff --git a/src/Mutator/Unwrap/AbstractUnwrapMutator.php b/src/Mutator/Unwrap/AbstractUnwrapMutator.php
@@ -50,21 +50,25 @@ abstract class AbstractUnwrapMutator extends Mutator
      */
     final public function mutate(Node $node)
     {
-        return $node->args[$this->getParameterIndex()];
+        foreach ($this->getParameterIndex($node) as $index) {
+            yield $node->args[$index];
+        }
     }
 
     abstract protected function getFunctionName(): string;
 
-    abstract protected function getParameterIndex(): int;
+    abstract protected function getParameterIndex(Node $node): \Generator;
 
     final protected function mutatesNode(Node $node): bool
     {
         if (!$node instanceof Node\Expr\FuncCall) {
             return false;
         }
 
-        if (!array_key_exists($this->getParameterIndex(), $node->args)) {
-            return false;
+        foreach ($this->getParameterIndex($node) as $index) {
+            if (!array_key_exists($index, $node->args)) {
+                return false;
+            }
         }
 
         return $node->name->toLowerString() === strtolower($this->getFunctionName());

diff --git a/src/Mutator/Unwrap/UnwrapArrayFilter.php b/src/Mutator/Unwrap/UnwrapArrayFilter.php
@@ -35,6 +35,8 @@
 
 namespace Infection\Mutator\Unwrap;
 
+use PhpParser\Node;
+
 /**
  * @internal
  */
@@ -45,8 +47,8 @@ protected function getFunctionName(): string
         return 'array_filter';
     }
 
-    protected function getParameterIndex(): int
+    protected function getParameterIndex(Node $node): \Generator
     {
-        return 0;
+        yield 0;
     }
 }
diff --git a/src/Mutator/Unwrap/UnwrapArrayFlip.php b/src/Mutator/Unwrap/UnwrapArrayFlip.php
@@ -35,6 +35,8 @@
 
 namespace Infection\Mutator\Unwrap;
 
+use PhpParser\Node;
+
 /**
  * @internal
  */
@@ -45,8 +47,8 @@ protected function getFunctionName(): string
         return 'array_flip';
     }
 
-    protected function getParameterIndex(): int
+    protected function getParameterIndex(Node $node): \Generator
     {
-        return 0;
+        yield 0;
     }
 }
diff --git a/src/Mutator/Unwrap/UnwrapArrayMap.php b/src/Mutator/Unwrap/UnwrapArrayMap.php
@@ -35,6 +35,8 @@
 
 namespace Infection\Mutator\Unwrap;
 
+use PhpParser\Node;
+
 /**
  * @internal
  */
@@ -45,8 +47,8 @@ protected function getFunctionName(): string
         return 'array_map';
     }
 
-    protected function getParameterIndex(): int
+    protected function getParameterIndex(Node $node): \Generator
     {
-        return 1;
+        yield 1;
     }
 }
diff --git a/src/Mutator/Unwrap/UnwrapArrayReduce.php b/src/Mutator/Unwrap/UnwrapArrayReduce.php
@@ -35,6 +35,8 @@
 
 namespace Infection\Mutator\Unwrap;
 
+use PhpParser\Node;
+
 /**
  * @internal
  */
@@ -45,8 +47,8 @@ protected function getFunctionName(): string
         return 'array_reduce';
     }
 
-    protected function getParameterIndex(): int
+    protected function getParameterIndex(Node $node): \Generator
     {
-        return 2;
+        yield 2;
     }
 }
diff --git a/src/Mutator/Unwrap/UnwrapArrayReplace.php b/src/Mutator/Unwrap/UnwrapArrayReplace.php
@@ -35,35 +35,20 @@
 
 namespace Infection\Mutator\Unwrap;
 
-use Infection\Mutator\Util\Mutator;
 use PhpParser\Node;
 
 /**
  * @internal
  */
-final class UnwrapArrayReplace extends Mutator
+final class UnwrapArrayReplace extends AbstractUnwrapMutator
 {
-    /**
-     * Replaces "$a = array_replace($array1, $array1);" with
-     *
-     * - "$a = $array1;
-     * - "$a = $array2;
-     *
-     * @return Node\Param;
-     */
-    public function mutate(Node $node)
+    protected function getFunctionName(): string
     {
-        foreach ($node->args as $arg) {
-            yield $arg;
-        }
+        return 'array_replace';
     }
 
-    protected function mutatesNode(Node $node): bool
+    protected function getParameterIndex(Node $node): \Generator
     {
-        if (!$node instanceof Node\Expr\FuncCall) {
-            return false;
-        }
-
-        return $node->name->toLowerString() === 'array_replace';
+        yield from array_keys($node->args);
     }
 }
diff --git a/src/Mutator/Unwrap/UnwrapArrayReverse.php b/src/Mutator/Unwrap/UnwrapArrayReverse.php
@@ -35,6 +35,8 @@
 
 namespace Infection\Mutator\Unwrap;
 
+use PhpParser\Node;
+
 /**
  * @internal
  */
@@ -45,8 +47,8 @@ protected function getFunctionName(): string
         return 'array_reverse';
     }
 
-    protected function getParameterIndex(): int
+    protected function getParameterIndex(Node $node): \Generator
     {
-        return 0;
+        yield 0;
     }
 }
diff --git a/src/Mutator/Unwrap/UnwrapStrRepeat.php b/src/Mutator/Unwrap/UnwrapStrRepeat.php
@@ -35,6 +35,8 @@
 
 namespace Infection\Mutator\Unwrap;
 
+use PhpParser\Node;
+
 /**
  * @internal
  */
@@ -45,8 +47,8 @@ protected function getFunctionName(): string
         return 'str_repeat';
     }
 
-    protected function getParameterIndex(): int
+    protected function getParameterIndex(Node $node): \Generator
     {
-        return 0;
+        yield 0;
     }
 }