Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement UnwrapStrToLower mutator #534

Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Oct 31, 2018

This PR

Related to #514.

πŸ’β€β™‚οΈ Follows the example in #513.

maks-rafalko
maks-rafalko previously approved these changes Oct 31, 2018
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

src/Mutator/Util/MutatorProfile.php Outdated Show resolved Hide resolved
@localheinz localheinz changed the title Enhancement: Implement UnwrapStrtolower mutator Enhancement: Implement UnwrapStrToLower mutator Oct 31, 2018
maks-rafalko
maks-rafalko previously approved these changes Oct 31, 2018
@maks-rafalko
Copy link
Member

could you please resolve conflict before merge @localheinz ?

@localheinz localheinz force-pushed the feature/unwrap-strtolower branch 2 times, most recently from 08c58e3 to 196ec14 Compare November 2, 2018 06:58
@maks-rafalko
Copy link
Member

this needs to be rebased and changed to use yield before merging. Could you please do that @localheinz?

@maks-rafalko
Copy link
Member

Thank you @localheinz

@maks-rafalko maks-rafalko merged commit a76e43f into infection:master Nov 3, 2018
@localheinz localheinz deleted the feature/unwrap-strtolower branch November 3, 2018 23:11
@localheinz
Copy link
Member Author

Thank you, @borNfreee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants