Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 772] Deprecate Bower support #9707

Merged

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Dec 7, 2021

Implements RFC 772.

I think this is ready for review, but marking it as draft as the RFC is still in FCP.

I know the current deprecation utility doesn't support the third argument, but this way the details are already present.

@bertdeblock bertdeblock marked this pull request as ready for review December 8, 2021 18:12
@bertdeblock bertdeblock force-pushed the rfc-772-deprecate-bower-support branch 2 times, most recently from 9e7a021 to 4260574 Compare December 10, 2021 18:01
@bertdeblock
Copy link
Contributor Author

@rwjblue Do you know if the failure is related to this PR or can we just try and re-run CI?

auto-merge was automatically disabled December 24, 2021 13:00

Head branch was pushed to by a user without write access

@bertdeblock bertdeblock force-pushed the rfc-772-deprecate-bower-support branch from 474b550 to ab7b2b2 Compare December 24, 2021 13:00
@rwjblue
Copy link
Member

rwjblue commented Jan 5, 2022

Now that the other PR is landed, would you mind rebasing?

@bertdeblock bertdeblock force-pushed the rfc-772-deprecate-bower-support branch from ab7b2b2 to 8d43e54 Compare January 5, 2022 19:26
@bertdeblock
Copy link
Contributor Author

@rwjblue Should be good to go.

@bertdeblock bertdeblock force-pushed the rfc-772-deprecate-bower-support branch from af6dea7 to ef78fba Compare January 19, 2022 19:20
@kategengler kategengler merged commit fdb393f into ember-cli:master Jan 19, 2022
@kategengler
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants