Add an assert and a deprecate utility
#9731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
debug-utils
branch
from
d3b3987
to
f2ce8fe
Compare
bertdeblock
force-pushed
the
debug-utils
branch
from
f2ce8fe
to
01577b4
Compare
bertdeblock
commented
Dec 15, 2021
| warn(message); | ||
| warn(getStackTrace()); | ||
|
|
||
| // Return the message for testing purposes. |
There was a problem hiding this comment.
I just noticed that in @ember/debug we noop console.warn and let deprecate throw during testing to do the necessary assertions. Should I do that here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
assertand adeprecateutility that use the same API as the ones provided by@ember/debug.The idea is that, in a follow-up PR a
registerDeprecationHandlerutility is introduced (similar to the one provided by@ember/debug) which can be used by tooling such as ember-cli-deprecation-workflow to handle deprecations more explicitly (e.g. throw instead of warn).If merged, I will create a PR to update the deprecations introduced in #9707 (or update that PR if this one is merged sooner).