Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower deprecations in ember-cli 4.3 #128

Closed
Windvis opened this issue Mar 16, 2022 · 5 comments · Fixed by #129
Closed

Bower deprecations in ember-cli 4.3 #128

Windvis opened this issue Mar 16, 2022 · 5 comments · Fixed by #129

Comments

@Windvis
Copy link

Windvis commented Mar 16, 2022

ember-cli 4.3 will include deprecations for all bower related apis. It seems that this addon is making use of some of those API's and since it's part of the default blueprint, these deprecations will be triggered when people start updating to the 4.3.

The easiest solution would be to simply drop bower support here and release a major version. Apps that do want the version checking for bower dependencies can stay on the v3 release? Alternatively we can manually replace the APIs with custom node code, so bower is still supported but the deprecations won't get triggered. I'm not sure if it's worth the time investment since I doubt projects on modern Ember are still using bower.

@quaertym
Copy link
Owner

I believe best way forward is to drop bower support.

@Windvis
Copy link
Author

Windvis commented Mar 22, 2022

I think the consensus in Discord was that we can't simply remove it here yet since it's still supported in ember-cli.

The idea was that we would add some bower detection code, and only then run the bower dependency checking code here. That way the deprecation messages from ember-cli won't be shown in apps that don't use bower.

Maybe it would be better to explicitly show a deprecation warning from this addon as well (if bower is detected), since otherwise it might not be clear that this addon is the cause for those other deprecation messages.

@SergeAstapov
Copy link
Contributor

@quaertym do you think #129 follows the spirit of that discussion? cc @Windvis

Also, we can do a major version bump of this package with:

  • dropping support for bower
  • requiring Node.js 14+ (this addon still has support Node.js 6)
  • bump all the dependencies

@Windvis
Copy link
Author

Windvis commented Apr 8, 2022

@SergeAstapov I think #129 is exactly what we needed. Thanks!

@quaertym
Copy link
Owner

quaertym commented Apr 8, 2022

@SergeAstapov Thanks for tackling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants