Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Bower #247

Merged
merged 1 commit into from Feb 4, 2022

Conversation

bertdeblock
Copy link
Collaborator

Since the Bower RFC implementation has been merged (I assume it will be part of the upcoming v4.2 release), I think we can start removing references to Bower from the guides?

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for ember-cli-guides ready!

🔨 Explore the source changes: f7c8955

🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-cli-guides/deploys/61faaa0b05e776000875334d

😎 Browse the preview: https://deploy-preview-247--ember-cli-guides.netlify.app

@locks
Copy link
Contributor

locks commented Jan 28, 2022

Are the CLI options you removed also removed in the implementation, or just deprecated? If they are just deprecated, I don't think they should be removed, even if we don't want to suggest usage of bower ;P

@bertdeblock
Copy link
Collaborator Author

bertdeblock commented Jan 28, 2022

At the moment, they are not removed nor do we display a deprecation warning when they are used (it was an open question in the RFC, but nobody mentioned something about it). I just assumed that since Bower support will be officially deprecated in v4.2, these could be removed from the docs as I thought the learning team did not want to teach APIs that are deprecated.

@locks
Copy link
Contributor

locks commented Jan 28, 2022

The Bower mentions in the diff already indicate that Bower should not be used, so it is not being recommended. And the CLI command reference was asked by community members because they didn't know how to get a list of all the options. It would be strange if it didn't match the actual output of the tool, I think.
I may be slightly biased because I'm working on a project that still uses Bower 😂

@jenweber
Copy link
Contributor

Thank you for this! I would like to keep all the proposed changes, with the exception of removing it from the CLI output. So if you can undo changes to guides/advanced-use/cli-commands-reference.md, then I'm all for this. Bower's website is totally covered in warnings, and so we can back off on ours. @locks does that sound ok?

@locks
Copy link
Contributor

locks commented Jan 28, 2022

I'm not sure about removing the hook, but as long as there are API docs I'm fine with what you said! [edit] in part because this is probably all going to have to be updated for addon format v2.

@bertdeblock
Copy link
Collaborator Author

I've reverted the changes related to the CLI output.

@jenweber
Copy link
Contributor

jenweber commented Feb 4, 2022

API documentation for addBowerPackageToProject is here: https://ember-cli.com/api/classes/blueprint#method_addBowerPackagesToProject

I'm going to open a PR to ember-cli api docs with the sentence about Bower itself being deprecated.

@jenweber jenweber merged commit bd0a31c into ember-learn:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants