New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to Bower #247
Conversation
✔️ Deploy Preview for ember-cli-guides ready! 🔨 Explore the source changes: f7c8955 🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-cli-guides/deploys/61faaa0b05e776000875334d 😎 Browse the preview: https://deploy-preview-247--ember-cli-guides.netlify.app |
Are the CLI options you removed also removed in the implementation, or just deprecated? If they are just deprecated, I don't think they should be removed, even if we don't want to suggest usage of bower ;P |
At the moment, they are not removed nor do we display a deprecation warning when they are used (it was an open question in the RFC, but nobody mentioned something about it). I just assumed that since Bower support will be officially deprecated in v4.2, these could be removed from the docs as I thought the learning team did not want to teach APIs that are deprecated. |
The Bower mentions in the diff already indicate that Bower should not be used, so it is not being recommended. And the CLI command reference was asked by community members because they didn't know how to get a list of all the options. It would be strange if it didn't match the actual output of the tool, I think. |
Thank you for this! I would like to keep all the proposed changes, with the exception of removing it from the CLI output. So if you can undo changes to |
I'm not sure about removing the hook, but as long as there are API docs I'm fine with what you said! [edit] in part because this is probably all going to have to be updated for addon format v2. |
e7160cd
to
f7c8955
Compare
I've reverted the changes related to the CLI output. |
API documentation for addBowerPackageToProject is here: https://ember-cli.com/api/classes/blueprint#method_addBowerPackagesToProject I'm going to open a PR to ember-cli api docs with the sentence about Bower itself being deprecated. |
Since the Bower RFC implementation has been merged (I assume it will be part of the upcoming
v4.2
release), I think we can start removing references to Bower from the guides?