Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deprecate Bower Support guides #1070

Merged

Conversation

bertdeblock
Copy link
Contributor

Guides for the Deprecate Bower Support RFC.
Implementation: ember-cli/ember-cli#9707.

@netlify
Copy link

netlify bot commented Jan 27, 2022

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit d06834e
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/625805d5d60cc30008ad89d9
😎 Deploy Preview https://deploy-preview-1070--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bertdeblock bertdeblock force-pushed the add-deprecate-bower-support-guides branch 4 times, most recently from 2a3ed87 to 3074bf2 Compare January 27, 2022 19:27
@bertdeblock bertdeblock force-pushed the add-deprecate-bower-support-guides branch from 3074bf2 to 1a59d81 Compare February 18, 2022 19:29
@bertdeblock bertdeblock force-pushed the add-deprecate-bower-support-guides branch from 1a59d81 to 92b0cb5 Compare March 7, 2022 08:50
@bertdeblock
Copy link
Contributor Author

Updated since: '4.2.0' to since: '4.3.0' everywhere:
https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md#v430-beta1

@bertdeblock bertdeblock force-pushed the add-deprecate-bower-support-guides branch from 92b0cb5 to d06834e Compare April 14, 2022 11:30
@@ -50,7 +50,8 @@
<li class="item list-unstyled">
<EmberVersionGraphic @mascot='zoey' @text='4.x' />
<ul class="links">
<li class="list-unstyled" data-test-ember-3-link><LinkTo @route='ember' @model='v4.x'>Ember</LinkTo></li>
<li class="list-unstyled" data-test-ember-4-link><LinkTo @route='ember' @model='v4.x'>Ember</LinkTo></li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data-test selector was incorrect here.

@locks locks merged commit cb1a634 into ember-learn:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants