Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump mongodb from 4.10.0 to 4.11.0 #2998

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2022

Bumps mongodb from 4.10.0 to 4.11.0.

Release notes

Sourced from mongodb's releases.

4.11.0

The MongoDB Node.js team is pleased to announce version 4.11.0 of the mongodb package!

Release Highlights

Recursive Schema Support

Version 4.3.0 of the Node driver added Typescript support for dot notation into our Filter type but in the process it broke support for recursive schemas. In 4.11.0, we now support recursive schemas and provide type safety on dot notation queries up to a depth of 9. Beyond a depth of 9, code still compiles but is no longer type checked (it falls back to a type of any).

interface CircularSchema {
    name: string;
    nestedSchema: CircularSchema;
}
// we have a collection of type Collection<CircularSchema>
// below a depth of 9, type checking is enforced
collection.findOne({ 'nestedSchema.nestedSchema.nestedSchema.name': 25 }) // compilation error - name must be a string
// at a depth greater than 9, code compiles but is not type checked (11 deep)
collection.findOne({
'nestedSchema.nestedSchema.nestedSchema.nestedSchema.nestedSchema.nestedSchema.nestedSchema.nestedSchema.nestedSchema.nestedSchema.name': 25
}) // NO compilation error

Note that our depth limit is a product of Typescript's recursive type limitations.

External Contributions

Many thanks to those who contributed to this release!

  • @​ermik provided an extremely large schema to test compilation with, which made testing our new recursive schema support possible with large schemas straightforward.
  • @​noahsilas for documentation improvements in change streams and fixing our Typescript types for read preferences.
  • @​zendagin for adding Typescript support for hashed indexes.
  • @​biniona-mongodb for fixing our parsing of TLS options.
  • @​LinusU for removing support for server versions lower than our minimum supported server version and improving error messages for unacknowledged writes with hints.

Features

  • NODE-3651: add hashed index type (#3432) (f6b56a1)
  • NODE-3875: support recursive schema types (#3433) (26bce4a)
  • NODE-4503: throw original error when server attaches NoWritesPerformed label (#3441) (a7dab96)
  • NODE-4650: handle handshake errors with SDAM (#3426) (cbe7533)
  • NODE-4721: add aws-sdk as optional dependency (#3446) (b879cb5)

... (truncated)

Changelog

Sourced from mongodb's changelog.

4.11.0 (2022-10-19)

Features

  • NODE-3255: add minPoolSizeCheckIntervalMS option to connection pool (#3429) (5f34ad0)
  • NODE-3651: add hashed index type (#3432) (f6b56a1)
  • NODE-3875: support recursive schema types (#3433) (26bce4a)
  • NODE-4503: throw original error when server attaches NoWritesPerformed label (#3441) (a7dab96)
  • NODE-4650: handle handshake errors with SDAM (#3426) (cbe7533)
  • NODE-4721: add aws-sdk as optional dependency (#3446) (b879cb5)

Bug Fixes

  • NODE-3712,NODE-4546: electionId should be ordered before setVersion (#3174) (ca51fec)
  • NODE-3921: error on invalid TLS option combinations (#3405) (1a550df)
  • NODE-4186: accept ReadPreferenceLike in TransactionOptions type (#3425) (dc62bcb)
  • NODE-4475: make interrupted message more specific (#3437) (5f37cb6)
  • NODE-4608: prevent parallel monitor checks (#3404) (78bcfe4)
  • NODE-4647: improve error message (#3409) (0d3c02e)
  • NODE-4649: use SDAM handling for errors from min pool size population (#3424) (ef3b55d)
Commits
  • 6fb87e4 chore(release): 4.11.0
  • 631455d docs(NODE-4724): update fle docs to use "in use encryption" terminology (#3448)
  • 7a8b186 docs(NODE-4554): remove experimental tag from disambiguatedPaths (#3450)
  • 8f06a55 chore(NODE-4700): update dependencies (#3439)
  • b879cb5 feat(NODE-4721): add aws-sdk as optional dependency (#3446)
  • 5f37cb6 fix(NODE-4475): make interrupted message more specific (#3437)
  • 26bce4a feat(NODE-3875): support recursive schema types (#3433)
  • a7dab96 feat(NODE-4503): throw original error when server attaches NoWritesPerformed ...
  • dbfb7d5 docs: Note special case in AbstractCursor.forEach() iterator (#3445)
  • bf000ae refactor(NODE-4689): track checked out connections (#3440)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mongodb](https://github.com/mongodb/node-mongodb-native) from 4.10.0 to 4.11.0.
- [Release notes](https://github.com/mongodb/node-mongodb-native/releases)
- [Changelog](https://github.com/mongodb/node-mongodb-native/blob/main/HISTORY.md)
- [Commits](mongodb/node-mongodb-native@v4.10.0...v4.11.0)

---
updated-dependencies:
- dependency-name: mongodb
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 24, 2022
@dependabot dependabot bot requested a review from a team October 24, 2022 00:02
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 24, 2022
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Oct 24, 2022
@apmmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-24T00:02:22.839+0000

  • Duration: 28 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 181642
Skipped 0
Total 181642

Steps errors 29

Expand to view the steps failures

Show only the first 10 steps failures

Archive the artifacts
  • Took 0 min 1 sec . View more details here
  • Description: [2022-10-24T00:20:39.983Z] Archiving artifacts script returned exit code 1
Run Tests
  • Took 4 min 26 sec . View more details here
  • Description: .ci/scripts/test.sh -b "release" -t "" "12"
Run Tests
  • Took 3 min 32 sec . View more details here
  • Description: .ci/scripts/test.sh -b "release" -t "" "12"
Archive the artifacts
  • Took 0 min 0 sec . View more details here
  • Description: [2022-10-24T00:20:19.325Z] Archiving artifacts script returned exit code 1
Archive the artifacts
  • Took 0 min 1 sec . View more details here
  • Description: [2022-10-24T00:20:25.897Z] Archiving artifacts script returned exit code 1
Run Tests
  • Took 4 min 7 sec . View more details here
  • Description: .ci/scripts/test.sh -b "release" -t "" "12.0"
Run Tests
  • Took 2 min 24 sec . View more details here
  • Description: .ci/scripts/test.sh -b "release" -t "" "12.0"
Archive the artifacts
  • Took 0 min 0 sec . View more details here
  • Description: [2022-10-24T00:19:51.524Z] Archiving artifacts script returned exit code 1
Archive the artifacts
  • Took 0 min 1 sec . View more details here
  • Description: [2022-10-24T00:19:54.938Z] Archiving artifacts script returned exit code 1
Run Tests
  • Took 4 min 4 sec . View more details here
  • Description: .ci/scripts/test.sh -b "release" -t "" "8"

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member

trentm commented Oct 24, 2022

The monster package-lock diff is from the huge added optionalDependency in mongodb in mongodb/node-mongodb-native#3446

@trentm
Copy link
Member

trentm commented Oct 24, 2022

Tests with contextManager: 'patch' are failing.

I strongly suspect this is because mongodb internals have been switched to use async/await rather than being based on callbacks. The callback usage of, e.g., mongodbClient.connect(callback) is already deprecated. I think the changes are all/mostly from mongodb/node-mongodb-native#3428

Given that contextManager: 'patch' is deprecated, we could just skip testing with mongodb >=4.11.0 && contextManager='patch' ... and we should just not instrument in that case, because we know it won't work properly.

I think we should also consider updating mongodb.test.js to use the promise/async/await-usage of the client instead of the current callback usage -- unless explicitly testing the callback usage. However, this could be punted to future mongodb@5 support when, presumably, they will drop callback support.

@trentm trentm self-assigned this Oct 24, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 21, 2022

Superseded by #3038.

@dependabot dependabot bot closed this Nov 21, 2022
APM-Agents (OLD) automation moved this from In Progress to Done Nov 21, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/mongodb-4.11.0 branch November 21, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants