Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3255): add minPoolSizeCheckIntervalMS option to connection pool #3429

Merged
merged 7 commits into from Sep 30, 2022
Merged

feat(NODE-3255): add minPoolSizeCheckIntervalMS option to connection pool #3429

merged 7 commits into from Sep 30, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Sep 29, 2022 •
edited

Description

NODE-3255

What is changing?

  • Added minPoolSizeCheckIntervalMS option to the connection pool which controls how frequently the ensureMinPoolSize runs
    • Added a unit test for the option and the default of 100ms
  • The corresponding backgroundThreadIntervalMS option in the CMAP test runner is now correctly parsed and passed to the test pools
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Better spec testing

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

dariakp
dariakp commented Sep 29, 2022
View reviewed changes
src/cmap/connection_pool.ts Outdated Show resolved Hide resolved
dariakp
dariakp commented Sep 29, 2022
View reviewed changes
src/cmap/connection_pool.ts Outdated Show resolved Hide resolved
dariakp
dariakp commented Sep 29, 2022
View reviewed changes
src/cmap/connection_pool.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken self-requested a review September 30, 2022 14:50
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 30, 2022
@dariakp dariakp force-pushed the NODE-3255/cmap-background-interval-option branch from bc00803 to 8f89bb8 Compare September 30, 2022 16:24
nbbeeken
nbbeeken previously approved these changes Sep 30, 2022
View reviewed changes
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 30, 2022
baileympearson
baileympearson requested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also commented on slack - minPoolsizeCheckFrequencyMS instead to match our existing options heartbeatFrequencyMS and minHeartbeatFrequencyMS?

test/integration/server-selection/server_selection.prose.operation_count.test.ts Show resolved Hide resolved
@nbbeeken nbbeeken merged commit 5f34ad0 into main Sep 30, 2022
@nbbeeken nbbeeken deleted the NODE-3255/cmap-background-interval-option branch September 30, 2022 19:57
ZLY201 pushed a commit to ZLY201/node-mongodb-native that referenced this pull request Nov 5, 2022
@dariakp @ZLY201
feat(NODE-3255): add minPoolSizeCheckIntervalMS option to connection …
1528de8 
…pool (mongodb#3429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@dariakp @nbbeeken @baileympearson