Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-4724): update fle docs to use "in use encryption" terminology #3448

Merged
merged 5 commits into from Oct 18, 2022

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Docs

What is the motivation for this change?

Consistency across documentation

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more:

// Legacy Options, these are unused but left here to avoid errors with CSFLE lib

Edit: this actually doesn't matter I think as it's referring to the module and not either of the 2 features. Disregard.

durran
durran previously approved these changes Oct 18, 2022
@dariakp dariakp added the Team Review Needs review from team label Oct 18, 2022
src/collection.ts Outdated Show resolved Hide resolved
src/deps.ts Outdated Show resolved Hide resolved
src/collection.ts Outdated Show resolved Hide resolved
src/collection.ts Outdated Show resolved Hide resolved
src/mongo_client.ts Outdated Show resolved Hide resolved
@dariakp dariakp merged commit 631455d into main Oct 18, 2022
@dariakp dariakp deleted the NODE-4679-fle-docs branch October 18, 2022 19:55
ZLY201 pushed a commit to ZLY201/node-mongodb-native that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants