Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4503): throw original error when server attaches NoWritesPerformed label #3441

Merged
merged 1 commit into from Oct 13, 2022
Merged

feat(NODE-4503): throw original error when server attaches NoWritesPerformed label #3441

merged 1 commit into from Oct 13, 2022

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

We inspect our error from retrying the operation and throw the original if a NoWritesPerformed label is attached.

What is the motivation for this change?

Shows the more relevant cause for error

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title NODE-4503-NoWritesPerformed feat(NODE-4503): throw original error when server attaches NoWritesPerformed label Oct 10, 2022
@nbbeeken nbbeeken force-pushed the NODE-4503-NoWritesPerformed branch 2 times, most recently from 90e0bc3 to 84761df Compare October 10, 2022 20:51
@nbbeeken nbbeeken marked this pull request as ready for review October 10, 2022 21:34
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 11, 2022
@durran durran self-assigned this Oct 11, 2022
@durran durran removed their assignment Oct 12, 2022
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 12, 2022
@durran durran merged commit a7dab96 into main Oct 13, 2022
@durran durran deleted the NODE-4503-NoWritesPerformed branch October 13, 2022 07:45
ZLY201 pushed a commit to ZLY201/node-mongodb-native that referenced this pull request Nov 5, 2022
@nbbeeken @ZLY201
feat(NODE-4503): throw original error when server attaches NoWritesPe…
3178115 
…rformed label (mongodb#3441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@nbbeeken @durran @baileympearson