Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NODE-4689): track checked out connections #3440

Merged

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 7, 2022

https://jira.mongodb.org/browse/NODE-4094

Description

What is changing?

The connection pool now tracks checked out connections instead of only keeping track of the number of checked out connections.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

https://jira.mongodb.org/browse/NODE-4094

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review October 10, 2022 14:06
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of points for discussion

src/cmap/connection_pool.ts Show resolved Hide resolved
src/cmap/connection_pool.ts Outdated Show resolved Hide resolved
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 11, 2022
@dariakp dariakp requested a review from nbbeeken October 11, 2022 20:56
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 12, 2022
@dariakp dariakp merged commit bf000ae into mongodb:main Oct 12, 2022
ZLY201 pushed a commit to ZLY201/node-mongodb-native that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
4 participants