Drop support for PHP < 7.1 and Symfony < 3.4

[alcaeus]

As per discussion in Slack and #885, this PR removes support for PHP < 7.1 (as they are no longer supported) as well as Symfony < 3.4 (since they are in security support only). This will target the 1.11 minor release.

The remaining build failure is due to a deprecation which isn't ignored in the Symfony 3.4 build. I have no idea which dependency combination causes that, so if anyone would have a few pointers for me, they'd be very much appreciated.

[alcaeus]

@doctrine/team-symfony-integration Anyone know where the deprecation in https://travis-ci.org/doctrine/DoctrineBundle/jobs/466345293 is coming from? It only happens in the Symfony 3.4 build where we lock all our explicit dependencies to Symfony 3.4 (but allow newer versions of other dependencies). I can't quite figure it out what's triggering it...

[greg0ire]

@alcaeus you could try getting a stack trace by using SYMFONY_DEPRECATIONS_HELPER=/MessageSelector/

[alcaeus]

Thanks for the hint! I traced it to the service container but I'm not sure what the root cause is:

The "Symfony\Component\Translation\MessageSelector" class is deprecated since Symfony 4.2, use IdentityTranslator instead.
Stack trace:
#0 vendor/symfony/translation/MessageSelector.php(14): trigger_error('The "Symfony\\Co...', 16384)
#1 vendor/composer/ClassLoader.php(444): include('/Users/abraun/C...')
#2 vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/Users/abraun/C...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('Symfony\\Compone...')
#4 /private/var/folders/rn/1wpg9zfn4gbd84dl26xzbfzm0000gn/T/sf_kernel_15f0720cc98d408ed5540a9748774e29/cache/test/ContainerB38ugye/sf_kernel_15f0720cc98d408ed5540a9748774e29TestDebugProjectContainer.php(567): spl_autoload_call('Symfony\\Compone...')
#5 /private/var/folders/rn/1wpg9zfn4gbd84dl26xzbfzm0000gn/T/sf_kernel_15f0720cc98d408ed5540a9748774e29/cache/test/ContainerB38ugye/getValidator_BuilderService.php(21): ContainerB38ugye\sf_kernel_15f0720cc98d408ed5540a9748774e29TestDebugProjectContainer->getTranslator_DefaultService()
#6 /private/var/folders/rn/1wpg9zfn4gbd84dl26xzbfzm0000gn/T/sf_kernel_15f0720cc98d408ed5540a9748774e29/cache/test/ContainerB38ugye/sf_kernel_15f0720cc98d408ed5540a9748774e29TestDebugProjectContainer.php(346): require('/private/var/fo...')
#7 /private/var/folders/rn/1wpg9zfn4gbd84dl26xzbfzm0000gn/T/sf_kernel_15f0720cc98d408ed5540a9748774e29/cache/test/ContainerB38ugye/getValidator_Mapping_CacheWarmerService.php(8): ContainerB38ugye\sf_kernel_15f0720cc98d408ed5540a9748774e29TestDebugProjectContainer->load('getValidator_Bu...')
#8 /private/var/folders/rn/1wpg9zfn4gbd84dl26xzbfzm0000gn/T/sf_kernel_15f0720cc98d408ed5540a9748774e29/cache/test/ContainerB38ugye/sf_kernel_15f0720cc98d408ed5540a9748774e29TestDebugProjectContainer.php(346): require('/private/var/fo...')
#9 /private/var/folders/rn/1wpg9zfn4gbd84dl26xzbfzm0000gn/T/sf_kernel_15f0720cc98d408ed5540a9748774e29/cache/test/ContainerB38ugye/getCacheWarmerService.php(9): ContainerB38ugye\sf_kernel_15f0720cc98d408ed5540a9748774e29TestDebugProjectContainer->load('getValidator_Ma...')
#10 vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php(43): ContainerB38ugye\sf_kernel_15f0720cc98d408ed5540a9748774e29TestDebugProjectContainer->{closure}()
#11 vendor/symfony/http-kernel/Kernel.php(554): Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp('/private/var/fo...')
#12 vendor/symfony/http-kernel/Kernel.php(123): Symfony\Component\HttpKernel\Kernel->initializeContainer()
#13 Tests/Command/ImportMappingDoctrineCommandTest.php(28): Symfony\Component\HttpKernel\Kernel->boot()
#14 vendor/phpunit/phpunit/src/Framework/TestCase.php(725): Doctrine\Bundle\DoctrineBundle\Tests\Command\ImportMappingDoctrineCommandTest->setup()
#15 {main}

[alcaeus]

Thanks @ostrolucky for finding the cause of the deprecation. For now, I changed the deprecation helper config to report all deprecations without failing the build - this solves the issue regardless of whether it's fixed upstream.

[ostrolucky]

How about setting SYMFONY_DEPRECATIONS_HELPER=1 instead? That would ignore the current deprecation, but alert us when count increases, which might be useful

[ostrolucky]

Can you please remove argument for HttpKernelExtension in setUp method of ProfilerTest? It seems it's no longer needed. I think it was for older versions too

[alcaeus]

@ostrolucky

Can you please remove argument for HttpKernelExtension in setUp method of ProfilerTest? It seems it's no longer needed. I think it was for older versions too

Will do 👍

How about setting SYMFONY_DEPRECATIONS_HELPER=1 instead? That would ignore the current deprecation, but alert us when count increases, which might be useful

I'd rather not have the build fail on deprecations in older builds to prevent regressions like the one before (where a newer version of a peer dependency triggers a deprecation). The tests against the latest version should fail when deprecations arise, so we should spot them soon enough 👍

[alcaeus]

@ostrolucky apparently that argument is still required, the build against the lowest set of dependencies fails without it.

[ostrolucky]

Yeah, it installed TwigBridge 2.8 heh

[ostrolucky]

Not worth doing job of cs fixers manually

[greg0ire]

Is there a fixer for this?

[ostrolucky]

https://github.com/Symplify/CodingStandard#parameters-arguments-and-array-items-should-be-on-the-samestandalone-line-to-fit-line-length

[alcaeus]

@greg0ire I'll work on the todo, completely forgot about that, sorry.

As for CS, I'd like to avoid style changes in this PR. doctrine/coding-standard also doesn't have any line-length rules, so I'd like to direct discussion about that to https://github.com/doctrine/coding-standard so we can come up with consistent rules on that. Thanks!

[greg0ire]

Waiting for the todo then

[kimhemsoe]

We should look into the CS afterwards

Todo fixed

[greg0ire]

I'm AFK for a week so cannot create the cs discussion, especially since it seems to mean creating a PR, but feel free to