Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue with merge up from 1.10 into master? #952

Closed
dmaicher opened this issue Apr 7, 2019 · 1 comment
Closed

issue with merge up from 1.10 into master? #952

dmaicher opened this issue Apr 7, 2019 · 1 comment
Assignees
@alcaeus
Labels
⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming

Comments

@dmaicher
Copy link
Contributor

dmaicher commented Apr 7, 2019

@alcaeus as mentioned I think something went wrong while merging some changes into master.

See
symfony/symfony#30948
#950 (comment)
@dmaicher dmaicher changed the title issue with merge up from 1.10 into master issue with merge up from 1.10 into master? Apr 7, 2019
@alcaeus
Copy link
Member

alcaeus commented Apr 7, 2019

After digging into the code and analysing this we found out that this wasn't an issue with merging up to master but rather the code was inadvertently removed in #892. Closing here as there are no other merge issues.

@alcaeus alcaeus closed this as completed Apr 7, 2019
@alcaeus alcaeus added the ⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 7, 2019
@alcaeus alcaeus self-assigned this Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alcaeus alcaeus

Labels
⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alcaeus @dmaicher