Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Symfony < 3.4 #928

Merged
merged 1 commit into from Apr 2, 2019
Merged

Drop support for Symfony < 3.4 #928

merged 1 commit into from Apr 2, 2019

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Mar 13, 2019

Follow up of #892

@alcaeus alcaeus self-assigned this Mar 14, 2019
alcaeus
alcaeus approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good; waiting for #929 to be merged to fix the build.

@alcaeus alcaeus added this to 1.11 in Roadmap Mar 14, 2019
@alcaeus alcaeus added this to the 1.11.0 milestone Apr 2, 2019
@alcaeus
Copy link
Member

alcaeus commented Apr 2, 2019

Thanks @rosier!

@alcaeus alcaeus merged commit ab34380 into doctrine:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

@SenseException SenseException SenseException approved these changes

Assignees

@alcaeus alcaeus

Labels
Improvement
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rosier @alcaeus @SenseException