You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
In cross-component environment when FrameworkBundle is 3.4.* and Translation is 4.2.*, deprecated MessageSelector is being used by default, which triggers deprecation and fails the build
Possible Solution
Check from inside compiler pass in FrameworkBundle if default translator service is being used with default MessageSelector service and if so, replace it with identity translator?
The text was updated successfully, but these errors were encountered:
I didn't have a look at this specific case to see which deprecated code path is taken.
But in the generic case, we can't make any promises about running old versions deprecations free.
Only 4.2 components are covered, for deprecations introduced in 4.2.
Yeah I know you can't, that would require you to test it and testing all the possible combination of components would be tough. These issues can still be fixed at least retroactively. Not fixing such issues might lead ecosystem to locking out installing component versions which introduce these deprecations or silencing the deprecations helper. Both would weaken the test suite.
As far as I understood correctly, the doctrine bundle failure was due to a badly configured bridge: running the bundle's test suite with Symfony 3.4 should ignore deprecations for sure.
Only the matrix with Symfony 4.2 should fail on deprecations.
Closing as this is expected. Providing forward compat of 3.4 with 4.2 is out of maintenance work.
Symfony version(s) affected: 3.4.*
Description
In cross-component environment when FrameworkBundle is 3.4.* and Translation is 4.2.*, deprecated MessageSelector is being used by default, which triggers deprecation and fails the build
How to reproduce
doctrine/DoctrineBundle#892
Possible Solution
Check from inside compiler pass in FrameworkBundle if default translator service is being used with default MessageSelector service and if so, replace it with identity translator?
The text was updated successfully, but these errors were encountered: