Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for php <7.1 #885

Closed
kimhemsoe opened this issue Dec 4, 2018 · 4 comments
Closed

Drop support for php <7.1 #885

kimhemsoe opened this issue Dec 4, 2018 · 4 comments
Assignees
@kimhemsoe
Milestone
1.11.0

Comments

@kimhemsoe
Copy link
Member

kimhemsoe commented Dec 4, 2018 •
edited

@jwage Would it be an issue to drop support for 5.5 here and now?

My reasoning is that 5.5 have not been supported for quite a while and we should push towards getting the bundle to 7.1 so we align better with the other bundles
@kimhemsoe kimhemsoe added this to the 1.10.1 milestone Dec 4, 2018
@kimhemsoe kimhemsoe self-assigned this Dec 4, 2018
@alcaeus
Copy link
Member

alcaeus commented Dec 4, 2018 •
edited

I've talked to @weaverryan about this and we agreed that it would be ok to drop PHP < 7.1 from the bundles. I would suggest doing so in a minor release though, not in a patch release like the milestone suggests. Just to be safe, ping @doctrine/team-symfony-integration.

@kimhemsoe kimhemsoe modified the milestones: 1.10.1, 1.11.0 Dec 4, 2018
@kimhemsoe
Copy link
Member Author

@alcaeus OK drop 5.x in 1.11 then and 7.0 in next 1.12 or 2.0?

@alcaeus
Copy link
Member

alcaeus commented Dec 4, 2018

Drop 5.x and 7.0 in 1.11 😉

@kimhemsoe kimhemsoe changed the title Drop support for php 5.5 Drop support for php >=7.0 Dec 4, 2018
@kimhemsoe kimhemsoe changed the title Drop support for php >=7.0 Drop support for php <7.1 Dec 4, 2018
@alcaeus alcaeus mentioned this issue Dec 10, 2018
Merged
@alcaeus
Copy link
Member

alcaeus commented Dec 23, 2018

Closing now that #892 has been merged.

@alcaeus alcaeus closed this as completed Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimhemsoe kimhemsoe

Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
2 participants
@alcaeus @kimhemsoe