Make the PhishingController test synchronous
#929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
make-test-synchronous
branch
from
73a99a9
to
431505b
Compare
Gudahtt
force-pushed
the
make-test-synchronous
branch
from
431505b
to
1be25dd
Compare
|
Should we add a test that simulates the issue we just ran into to enforce/demonstrate the broken up pattern - that is to say separating out calls to update the lists and run the check? Or otherwise add comments somewhere about why we want to keep |
|
Oh, good point. This is incomplete. |
Gudahtt
force-pushed
the
make-test-synchronous
branch
from
ffb5b9d
to
ab19822
Compare
Gudahtt
changed the title
test synchronous againtest synchronous
Gudahtt
force-pushed
the
make-test-synchronous
branch
from
ab19822
to
b30177f
Compare
Gudahtt
changed the base branch from
main
to
prevent-parallel-phishing-updates
|
This PR is now based on #930 , so we'll need to merge that one first. It ended up being easier to reverse the order, |
Gudahtt
force-pushed
the
make-test-synchronous
branch
2 times, most recently
from
b06052b
to
facb31f
Compare
The `test` method for the PhishingController was recently made asynchronous so that it could update the phishing configuration if necessary. We found that in practice this was difficult to use, especially when handling multiple simultanous tests. The `test` method has been made synchronous again. Instead we can check whether the config is out of date using the new `isOutOfDate` method, and explicitly update the configuration if required.
Gudahtt
force-pushed
the
make-test-synchronous
branch
from
facb31f
to
b6595dd
Compare
|
This should be ready to review now. Additional tests have been added to |
adonesky1
reviewed
Oct 10, 2022
adonesky1
reviewed
Oct 10, 2022
adonesky1
previously approved these changes
Oct 10, 2022
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
The `test` method for the PhishingController was recently made asynchronous so that it could update the phishing configuration if necessary. We found that in practice this was difficult to use, especially when handling multiple simultanous tests. The `test` method has been made synchronous again. Instead we can check whether the config is out of date using the new `isOutOfDate` method, and explicitly update the configuration if required.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `test` method for the PhishingController was recently made asynchronous so that it could update the phishing configuration if necessary. We found that in practice this was difficult to use, especially when handling multiple simultanous tests. The `test` method has been made synchronous again. Instead we can check whether the config is out of date using the new `isOutOfDate` method, and explicitly update the configuration if required.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `test` method for the PhishingController was recently made asynchronous so that it could update the phishing configuration if necessary. We found that in practice this was difficult to use, especially when handling multiple simultanous tests. The `test` method has been made synchronous again. Instead we can check whether the config is out of date using the new `isOutOfDate` method, and explicitly update the configuration if required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testmethod for the PhishingController was recently made asynchronous so that it could update the phishing configuration if necessary. We found that in practice this was difficult to use, especially when handling multiple simultaneous tests.The
testmethod has been made synchronous again. Instead we can check whether the config is out of date using the newisOutOfDatemethod, and explicitly update the configuration if required.BREAKING:
testmethod is now synchronous again.ADDED:
isOutOfDatemethod for checking whether the current configuration is outdatedChecklist