Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the PhishingController test synchronous #929

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Make the PhishingController test synchronous #929

merged 2 commits into from
Oct 10, 2022

Commits on Oct 10, 2022

  1. Make the PhishingController test synchronous again 

    The `test` method for the PhishingController was recently made
asynchronous so that it could update the phishing configuration if
necessary. We found that in practice this was difficult to use,
especially when handling multiple simultanous tests.

The `test` method has been made synchronous again. Instead we can check
whether the config is out of date using the new `isOutOfDate` method,
and explicitly update the configuration if required.
    @Gudahtt
    Gudahtt committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    b6595dd View commit details
    Browse the repository at this point in the history

  2. Use term 'phishing lists' over 'phishing configuration'

    @Gudahtt
    Gudahtt committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    21d9b47 View commit details
    Browse the repository at this point in the history