Skip to content

Commit

Permalink
Make the PhishingController test synchronous (#929)
Browse files Browse the repository at this point in the history 
The `test` method for the PhishingController was recently made
asynchronous so that it could update the phishing configuration if
necessary. We found that in practice this was difficult to use,
especially when handling multiple simultanous tests.

The `test` method has been made synchronous again. Instead we can check
whether the config is out of date using the new `isOutOfDate` method,
and explicitly update the configuration if required.
  • Loading branch information
@Gudahtt @MajorLift
Gudahtt authored and MajorLift committed Oct 11, 2023
1 parent 168b6b3 commit 2e548b6
Show file tree
Hide file tree
Showing 2 changed files with 129 additions and 194 deletions.

0 comments on commit 2e548b6

Please sign in to comment.