Skip to content

Commit

Permalink
Use term 'phishing lists' over 'phishing configuration'
Browse files Browse the repository at this point in the history
  • Loading branch information
Gudahtt committed Oct 10, 2022
1 parent b6595dd commit 21d9b47
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/third-party/PhishingController.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe('PhishingController', () => {
sinon.restore();
});

it('should set default state to the package phishing configuration', () => {
it('should set default state to the package phishing lists', () => {
const controller = new PhishingController();
expect(controller.state.phishing).toStrictEqual([
{
Expand Down Expand Up @@ -105,15 +105,15 @@ describe('PhishingController', () => {
await pendingUpdate;
});

it('should not be out of date if the configuration was just updated', async () => {
it('should not be out of date if the phishing lists were just updated', async () => {
sinon.useFakeTimers();
const controller = new PhishingController({ refreshInterval: 10 });
await controller.updatePhishingLists();

expect(controller.isOutOfDate()).toBe(false);
});

it('should not be out of date if the configuration was recently updated', async () => {
it('should not be out of date if the phishing lists were recently updated', async () => {
const clock = sinon.useFakeTimers();
const controller = new PhishingController({ refreshInterval: 10 });
await controller.updatePhishingLists();
Expand Down Expand Up @@ -614,7 +614,7 @@ describe('PhishingController', () => {
]);
});

it('should not update phishing configuration if disabled', async () => {
it('should not update phishing lists if disabled', async () => {
const controller = new PhishingController({ disabled: true });
await controller.updatePhishingLists();

Expand Down Expand Up @@ -687,7 +687,7 @@ describe('PhishingController', () => {
});

describe('an update is in progress', () => {
it('should not fetch configuration again', async () => {
it('should not fetch phishing lists again', async () => {
const clock = sinon.useFakeTimers();
const nockScope = nock(PHISHING_CONFIG_BASE_URL)
.get(METAMASK_CONFIG_FILE)
Expand Down

0 comments on commit 21d9b47

Please sign in to comment.