Skip to content

Commit

Permalink
Make the PhishingController test synchronous again
Browse files Browse the repository at this point in the history
The `test` method for the PhishingController was recently made
asynchronous so that it could update the phishing configuration if
necessary. We found that in practice this was difficult to use,
especially when handling multiple simultanous tests.

The `test` method has been made synchronous again. Instead we can check
whether the config is out of date using the new `isOutOfDate` method,
and explicitly update the configuration if required.
  • Loading branch information
Gudahtt committed Oct 7, 2022
1 parent 0b03d58 commit 1be25dd
Show file tree
Hide file tree
Showing 2 changed files with 69 additions and 180 deletions.

0 comments on commit 1be25dd

Please sign in to comment.