Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of PhishingController test #911

Closed
Gudahtt opened this issue Sep 14, 2022 · 1 comment
Closed

Improve speed of PhishingController test #911

Gudahtt opened this issue Sep 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Sep 14, 2022

The test function for the PhishingController was recently made async so that we can lazily update the configuration, rather than polling for updates on a set interval. This simplifies testing and MV3 compatibility. However it may cause a delay in how quickly MetaMask can respond to a blocked site by navigating away.

We should explore ways of speeding up this check, either at the product layer or here or both. For example, here we can check the configuration eagerly before getting the update, so that we only have a slow response time for newly blocked sites (at the expense of potentially blocking a recently-allowed site a single time).

@Gudahtt Gudahtt added the enhancement New feature or request label Sep 14, 2022
@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 11, 2022

This has been addressed partially by #929

The project can now decide what to do for itself when the phishing lists are outdated. It can check right away using the outdated configuration, wait until it's updated, or it can check before and after.

@Gudahtt Gudahtt closed this as completed Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant