chore: Adds chardet as prod dependency
#76
Conversation
Version 4.0.0 has been tested, so no breaking changes from 3.x.x fixes side-effect of `requirementslib` not specifying `chardet` as dep sarugaku/requirementslib#296 is still open User will not need to install `chardet` manually to use this package
|
Note: Fixes #73 |
|
@Madoshakalaka Would it be possible to merge this PR, or alternatively update the version of It's currently breaking our CI pipeline :( |
Pipfile.lock
Outdated
| "sha256:ecd2c3fe726758037234c93df7e98deb257fd15c24c9180dacf1ef829da5f921", | ||
| "sha256:ef565033fa5a958e62796867b1df10c40263ea9ded87164d67572834e57a174d" | ||
| ], | ||
| "markers": "python_version >= '3.9'", |
There was a problem hiding this comment.
@bryant-finney This must be a result of the interpreter I was using, not intentional! edit: I installed mypy manually, I can see what happened now
There was a problem hiding this comment.
hm, not the cause of mypy installation, I'll look into this now and see what went wrong.
There was a problem hiding this comment.
I have pushed another commit for you to review :)
There was a problem hiding this comment.
MIght be ye olde --keep-outdated flag to pipenv install that's missing, pipenv likes sneaky side effects :)
There was a problem hiding this comment.
Nice, thanks for digging in!
I'm trying to verify the Travis CI jobs are actually running / passing, but I'm not seeing any integrated GitHub widgets/components like I was expecting. Are you able to see the test status / logs / coverage results / etc?
I'm wondering if the CI integration needs to be updated after the migration from travis-ci.org to travis-ci.com
There was a problem hiding this comment.
@bryant-finney No probs!
I have the jobs saved, but the last few runs I've just tested with tox - I'm out of credits for Travis - and the tests have been on my fork. Not sure how the plan looks for this repo in particular.
I'm considering migrating the travis yaml file over to GH actions to view builds on my fork.
If you would like the logs for what I did collect I can email them your way.
There was a problem hiding this comment.
Gotcha, yeah I was also considering forking to GitLab. I have a repo somewhere that uses tox with Docker executors for its CI jobs, but right now I'm not sure how to run tests in a Windows environment using GitLab. Does GitHub actions support windows runners?
There was a problem hiding this comment.
From what I know at this moment, GH actions should be able to do what Travis can do, I'm curious to look into it, but so far I've only used it for ubuntu builds. The good thing about actions is its integrated right into the repository, and widgets aren't a problem like you mentioned earlier.
There was a problem hiding this comment.
Nice; I looked into it a little the other day. From what I understand, GitHub uses Azure-based infrastructure; so I would be very surprised if GitHub actions was unable to accommodate.
While looking, I saw that GitLab recently started providing windows executors as well. Since I'm already comfortable with GitLab pipelines, I went ahead and forked this project over to bryant.finney / pipenv-setup; that said, to me it seems better to use GitHub actions long-term.
So why don't we work on this in parallel? If CI/CD w/GitHub goes as quickly as one might hope, we can just drop the GitLab fork; otherwise, we can use the GitLab fork to run CI until we finish the GitHub actions integration. Does that sound reasonable to you?
Adding `chardet` to Pipfile seems to have changed the markers for `mypy` Compatibility for 3.7 broken; `six-stub` package is needed; can be added `chardet` moved to `dev-packages`
There was a problem hiding this comment.
I verified that pytest-mypy fails with the same error on master:
~/projects/github/pipenv-setup master* 19:48:04
❯ tox
GLOB sdist-make: /home/bryant/projects/github/pipenv-setup/setup.py
[ ... ]
============================================================ FAILURES ============================================================
__________________________________________________________ test session __________________________________________________________
mypy exited with status 1.
______________________________________________________ pipenv_setup/main.py ______________________________________________________
16: error: Library stubs not installed for "six" (or incompatible with Python 3.7)
16: note: Hint: "python3 -m pip install types-six"
16: note: (or run "mypy --install-types" to install all missing stub packages)
16: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
_________________________________________________ pipenv_setup/pipfile_parser.py _________________________________________________
6: error: Library stubs not installed for "six" (or incompatible with Python 3.7)I'll merge this PR now and open a second to fix mypy
Signed-off-by: Bryant Finney <finneybp@gmail.com>
- add `dev` dependency for `types-six` - require `pyparsing!=3.0.5` due to pyparsing/pyparsing#329 - update `pytest-mypy>=0.8` Signed-off-by: Bryant Finney <finneybp@gmail.com>
currently only installs `pyenv` and Python versions Signed-off-by: Bryant Finney <finneybp@gmail.com>
Signed-off-by: Bryant Finney <finneybp@gmail.com>
- add `dev` dependency for `types-six` - require `pyparsing!=3.0.5` due to pyparsing/pyparsing#329 - update `pytest-mypy>=0.8` Signed-off-by: Bryant Finney <finneybp@gmail.com>
Signed-off-by: Bryant Finney <finneybp@gmail.com>
- add `dev` dependency for `types-six` - require `pyparsing!=3.0.5` due to pyparsing/pyparsing#329 - update `pytest-mypy>=0.8` Signed-off-by: Bryant Finney <finneybp@gmail.com>
* Resolve GitLab [#76]: Update dependencies to resolve failing tests * ci: Adds .github/workflows/ci.yml * docs: Adds CI status badge to README.md Co-authored-by: Bryant Finney <finneybp@gmail.com>
Version 4.0.0 has been tested, so no breaking changes from 3.x.x
fixes side-effect of
requirementslibnot specifyingchardetas depsarugaku/requirementslib#296 is still open
User will not need to install
chardetmanually to use this package