Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: Library stubs not installed for "six" (or incompatible with Python 3.7) #77

Closed
jshwi opened this issue Nov 8, 2021 · 13 comments
Closed

Comments

@jshwi
Copy link
Contributor

jshwi commented Nov 8, 2021

In relation to: #76 (review)

@jshwi
Copy link
Contributor Author

jshwi commented Nov 8, 2021

@bryant-finney #75 (comment)
I don't have experience with Gitlab's CI, but while we're at it I could attempt to put together a GH action workflow for the points listed on the Gitlab fork.

@bryant-finney
Copy link
Collaborator

bryant-finney commented Nov 8, 2021

@jshwi
Sounds solid! I got the GitLab pipeline to run the test suite for Python 3.6, 3.7, and 3.8 (using the base Python Docker images for each). It'll be easy to extend for 3.9/3.10 whenever we get there.

I'm sure you noticed, but all three tox jobs failed haha.

I was able to get it to run locally with the following (IIRC; I had to hop off before I could commit and push):

  • add mypy = "*" to dev-packages
    • I think you can alternatively resolve the errors by upgrading pytest-mypy
  • add types-six = "*" to dev-packages
  • add pyparsing = ”~=2” to packages
    • this one was sneaky and took a while to track down

Hope that helps!

Also, I still need to update the issue, but I'd like to separate pytest and mypy into separate jobs.

@jshwi
Copy link
Contributor Author

jshwi commented Nov 8, 2021

@bryant-finney
Can be a bit hit and miss when running local/remote with the CI!
I need to look into how Gitlab does things.

If you're ever interested in checking out GH actions, and don't want to have to run remote to test, I've been using https://github.com/nektos/act with Docker.

I'll keep an eye on Gitlab so I'm no trying to re-invent the wheel :D

@bryant-finney
Copy link
Collaborator

bryant-finney commented Nov 8, 2021

@jshwi Oh nice! Thanks for sharing; I haven't used act before, so definitely good to know.

If you're interested in digging into GitLab's CI, I'd recommend installing gitlab-runner locally; you can then use it to run jobs with a faster iteration cycle.

I'm thinking to create another branch off of the MR for actually resolving the test jobs; I'll circle back when I push something!

@bryant-finney
Copy link
Collaborator

@jshwi

I just found pyparsing/pyparsing#329 ; that bug is actually what is responsible for the pyparsing issue I mentioned earlier haha

Setting pyparsing!=3.0.5 seems to be a better solution for this problem. After doing so, adding types-six, and updating pytest-mypy in 87300b, the tox jobs are passing :)

@jshwi
Copy link
Contributor Author

jshwi commented Nov 9, 2021

@bryant-finney #77 (comment)
I'll check that out, Gitlab seems to have a lot of good stuff out of the box

@bryant-finney That's a really good find, I tried adding the types as is, and it didn't work for me haha

@bryant-finney
Copy link
Collaborator

@jshwi yeah that's been my experience with GitLab: as an all-in-one solution for DevOps, it's pretty tightly integrated across the average project's SDLC.

On which note: I added jobs for executing the test suite using Windows-based runners in MR !78 😃 also, when making changes to Pipfile, I went ahead and ran prettier on the JSON/YAML/TOML files for consistency (ultimately I hope to configure pre-commit to handle these trivialities automatically).

@jshwi
Copy link
Contributor Author

jshwi commented Nov 10, 2021

@bryant-finney I made a gitlab account a few days ago, and I've added that fork as a remote :) I'm gonna playaround with gitlab for a bit.

I've tried your latest commit on the GH actions runner and it's looking good. I'm having a look at the travis config, and it looks like there's some complexity in running the osx builds per python version, but it should be pretty doable once I get into it.

Looks like this is coming back to life 😃

@bryant-finney
Copy link
Collaborator

@jshwi excellent! I haven't tried osx runners in GL yet; just windows runners. I know osx runners are supported, but it looks like the project needs to request them specifically. I'll have better info when I dig in again. 🙂

On which note, it might be a couple of days before I can get back to finishing that GL MR; but definitely don't hesitate to reach out if you need any permissions or anything!

@jshwi
Copy link
Contributor Author

jshwi commented Nov 10, 2021

@bryant-finney awesome! no sweat, I'll keep plodding along. if I need to I'll drop you a ping, but get back whenever you can, shouldn't be a problem. cheers 😄

@jshwi
Copy link
Contributor Author

jshwi commented Nov 11, 2021

@bryant-finney #79 preview, if you would like to review the progress

@jshwi
Copy link
Contributor Author

jshwi commented Nov 16, 2021

Would I be OK to close this one off? 😄

@bryant-finney
Copy link
Collaborator

@jshwi absolutely!

@jshwi jshwi closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants