Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds chardet as prod dependency #76

Merged
merged 3 commits into from
Nov 6, 2021
Merged

chore: Adds chardet as prod dependency #76

merged 3 commits into from
Nov 6, 2021

Commits on Nov 2, 2021

  1. chore: Adds chardet as prod dependency

    Version 4.0.0 has been tested, so no breaking changes from 3.x.x
    
    fixes side-effect of `requirementslib` not specifying `chardet` as dep
    sarugaku/requirementslib#296 is still open
    
    User will not need to install `chardet` manually to use this package
    jshwi committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    72eb526 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. fix: Adds mypy markers

    Adding `chardet` to Pipfile seems to have changed the markers for `mypy`
    Compatibility for 3.7 broken; `six-stub` package is needed; can be added
    `chardet` moved to `dev-packages`
    jshwi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6eb77c8 View commit details
    Browse the repository at this point in the history
  2. fix: Adds chardet as prod dependency

    Locked with `pipenv lock --keep-outdated`
    Less diff in Pipfile.lock vs b442e71 and 72eb526
    No other dep changes needed
    jshwi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    7fb9023 View commit details
    Browse the repository at this point in the history