-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/gh actions #79
ci/gh actions #79
Conversation
Force pushed, as the previous file was working with Pipenv, realised this wasn't possible (or implemented in .travis.yml). This works for all versions, next - Windows and OSX. |
Should be ready for review |
One last -f for caching pip as per setup.py hash. We could do it for the Pipfile instead though if preferred. |
Also please disregard the "Changes requested" / "pending" / "self-requested" review stuff; I clearly need more practice with GitHub PR reviews lol |
@bryant-finney will submit an update or two today. |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 10 10
Lines 745 745
=======================================
Hits 705 705
Misses 40 40 Continue to review full report at Codecov.
|
This has been condensed into 2 commits, hope that the rebase doesn't effect anyone negatively |
@jshwi this PR looks good to me! Does anything else still need to be added, or are your ready for merge? 🙂 |
@bryant-finney Just a quick side note, the link in the README was to my fork, I ammended that to point to this repo |
edit: #79 (comment)