Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/gh actions #79

Merged
merged 3 commits into from
Nov 16, 2021
Merged

ci/gh actions #79

merged 3 commits into from
Nov 16, 2021

Conversation

jshwi
Copy link
Contributor

@jshwi jshwi commented Nov 11, 2021

@jshwi
Copy link
Contributor Author

jshwi commented Nov 11, 2021

Screenshot from 2021-11-11 21-37-50
So far so good

@jshwi
Copy link
Contributor Author

jshwi commented Nov 12, 2021

Force pushed, as the previous file was working with Pipenv, realised this wasn't possible (or implemented in .travis.yml). This works for all versions, next - Windows and OSX.

@jshwi
Copy link
Contributor Author

jshwi commented Nov 12, 2021

Screenshot from 2021-11-12 16-28-16

@jshwi
Copy link
Contributor Author

jshwi commented Nov 12, 2021

Screenshot from 2021-11-12 22-33-46

@jshwi
Copy link
Contributor Author

jshwi commented Nov 12, 2021

Should be ready for review

@jshwi jshwi changed the title WIP: Ci/gh actions ci/gh actions Nov 12, 2021
@jshwi
Copy link
Contributor Author

jshwi commented Nov 12, 2021

One last -f for caching pip as per setup.py hash. We could do it for the Pipfile instead though if preferred.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@bryant-finney
Copy link
Collaborator

Also please disregard the "Changes requested" / "pending" / "self-requested" review stuff; I clearly need more practice with GitHub PR reviews lol

@jshwi
Copy link
Contributor Author

jshwi commented Nov 15, 2021

@bryant-finney will submit an update or two today.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #79 (3aa50fa) into master (2b66c23) will not change coverage.
The diff coverage is n/a.

❗ Current head 3aa50fa differs from pull request most recent head 57b3c88. Consider uploading reports for the commit 57b3c88 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files          10       10           
  Lines         745      745           
=======================================
  Hits          705      705           
  Misses         40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ee940...57b3c88. Read the comment docs.

@jshwi
Copy link
Contributor Author

jshwi commented Nov 15, 2021

This has been condensed into 2 commits, hope that the rebase doesn't effect anyone negatively

@bryant-finney
Copy link
Collaborator

@jshwi this PR looks good to me! Does anything else still need to be added, or are your ready for merge? 🙂

@jshwi
Copy link
Contributor Author

jshwi commented Nov 16, 2021

@bryant-finney
imo everything needed for an initial workflow is there, good to merge if you're ready

Just a quick side note, the link in the README was to my fork, I ammended that to point to this repo

@bryant-finney bryant-finney merged commit 488ce93 into Madoshakalaka:master Nov 16, 2021
@jshwi jshwi deleted the ci/gh-actions branch November 16, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants