Skip to content

Commit

Permalink
chore: Adds chardet as prod dependency (#76)
Browse files Browse the repository at this point in the history
* chore: Adds `chardet` as prod dependency

Version 4.0.0 has been tested, so no breaking changes from 3.x.x

fixes side-effect of `requirementslib` not specifying `chardet` as dep
sarugaku/requirementslib#296 is still open

User will not need to install `chardet` manually to use this package
  • Loading branch information
jshwi committed Nov 6, 2021
1 parent b442e71 commit 2a53b70
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 1 deletion.
1 change: 1 addition & 0 deletions Pipfile
Expand Up @@ -23,6 +23,7 @@ vistir = "~=0.4"
autopep8 = {markers = "python_version<'3.6'",version = "~=1.4"}
six = "~=1.12"
typing = {markers = "python_version<'3.7'", version = "~=3.7"}
chardet = ">=3.0.0, <=5.0.0"

[scripts]
# use this to sync this pipfile to setup.py, explained in CONTRIBUTING.md
Expand Down
58 changes: 57 additions & 1 deletion Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions setup.py
Expand Up @@ -155,6 +155,7 @@
"autopep8~=1.4; python_version < '3.6'",
"six~=1.12",
"typing~=3.7; python_version < '3.7'",
"chardet>=3.0.0,<=5.0.0",
], # Optional
entry_points={
"console_scripts": ["pipenv-setup=pipenv_setup.main:cmd"]
Expand Down

0 comments on commit 2a53b70

Please sign in to comment.