build(deps): bump rubocop from 1.17.0 to 1.18.0 in /Library/Homebrew #11626
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Library/Homebrew/.rubocop.yml
Outdated
| Naming/InclusiveLanguage: | ||
| FlaggedTerms: | ||
| whitelist: | ||
| # For an option passed to `srb` in dev-cmd/typecheck.rb | ||
| AllowedRegex: "--error-white-list" | ||
| # TODO: If possible, make this stricter. Some instances may be unavoidable, | ||
| # such as sqlite_master in unpack_strategy/fossil.rb but these can be | ||
| # handled using AllowedRegex. | ||
| master: |
There was a problem hiding this comment.
RuboCop added a new Naming/InclusiveLanguage cop in this release, which is enabled by default. Our codebase has many references to the master branch which is used as a fallback in many cases, or to refer to the HEAD/default branch of our official taps, which happen to be named master.
For the time being, I've replaced potentially problematic instances which can be safely replaced without breaking public API, but enabling the cop for the word "master" does not seem possible at this moment.
brew style gives me 39 offenses without disabling the check for "master", of which one seems to be a false positive (and I've mentioned this in the TODO comment).
There was a problem hiding this comment.
Makes sense, this is a nice middle-ground between reducing our use of the term but also allowing us to use this cop for other terms with our Git-heavy internal language.
Library/Homebrew/.rubocop.yml
Outdated
| Naming/InclusiveLanguage: | ||
| FlaggedTerms: | ||
| whitelist: | ||
| # For an option passed to `srb` in dev-cmd/typecheck.rb | ||
| AllowedRegex: "--error-white-list" | ||
| # TODO: If possible, make this stricter. Some instances may be unavoidable, | ||
| # such as sqlite_master in unpack_strategy/fossil.rb but these can be | ||
| # handled using AllowedRegex. | ||
| master: |
There was a problem hiding this comment.
Makes sense, this is a nice middle-ground between reducing our use of the term but also allowing us to use this cop for other terms with our Git-heavy internal language.
|
@nandahkrishna This will need rebased to pass CI 😭 |
|
I think it's failing because of syntax issues in homebrew/core too (and not just the Repology test) – working on a PR for that now 🙂. |
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
nandahkrishna
force-pushed
the
dependabot/bundler/Library/Homebrew/rubocop-1.18.0
branch
from
1a13851
to
4a19843
Compare
|
I've opened Homebrew/homebrew-core#80302 to fix style issues in formulae. I had to move the RuboCop changes to the common |
|
A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@dependabot recreate |
|
Superseded by #11642. |
dependabot
bot
deleted the
dependabot/bundler/Library/Homebrew/rubocop-1.18.0
branch
Bumps rubocop from 1.17.0 to 1.18.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
f1f6414Cut 1.188f3bde2Update Changelog9b5402d[Fixes #9144] Addaggressiveandconservativemodes for `Style/StringConc...0170f53Fix a typo89463f6Fix a false positive forLayout/ClosingParenthesisIndentation8ff511cUpdate changelog/fix_gem_version_not_respecting_tags.md19390caUpdate Bundler/GemVersion to check for branch, ref, and tag4326083[Fix #9803] FixBundler/GemVersioncop not respecting git tags356b22cFix indentation in Style/ClassAndModuleChildrenaadf475Fix a build errorDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)