Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Layout/LineLength #9882

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 17, 2021

This PR fixes an incorrect auto-correct for Layout/LineLength when using heredoc as the first method argument and omitting parentheses.

% cat example.rb
foo <<~RUBY, arg
RUBY

% bundle exec rubocop --only Layout/LineLength -a
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:16: C: [Corrected] Layout/LineLength: Line is too long. [16/15]
foo <<~RUBY, arg
               ^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
foo <<~RUBY,
arg
RUBY

% ruby -c example.rb
example.rb:1: syntax error, unexpected end-of-input

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes an incorrect auto-correct for `Layout/LineLength` when
using heredoc as the first method argument and omitting parentheses.

```console
% cat example.rb
foo <<~RUBY, arg
RUBY

% bundle exec rubocop --only Layout/LineLength -a
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:16: C: [Corrected] Layout/LineLength: Line is too long. [16/15]
foo <<~RUBY, arg
               ^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
foo <<~RUBY,
arg
RUBY

% ruby -c example.rb
example.rb:1: syntax error, unexpected end-of-input
```
@koic koic merged commit 981a8a2 into rubocop:master Jun 19, 2021
@koic koic deleted the fix_an_incorrect_autocorrect_for_layout_line_length branch June 19, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant