Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/RegexpLiteral #9880

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 16, 2021

This PR fixes the following false positive for Style/RegexpLiteral when using a regexp starts with a blank as a method argument.

% cat example.rb
do_something %r| regexp|

% bundle exec rubocop --only Style/RegexpLiteral -a
(snip)

Offenses:

example.rb:1:14: C: [Corrected] Style/RegexpLiteral: Use // around regular expression.
do_something %r| regexp|
             ^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
do_something / regexp/

% ruby -c example.rb
example.rb:1: syntax error, unexpected end-of-input

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following false positive for `Style/RegexpLiteral`
when using a regexp starts with a blank as a method argument.

```console
% cat example.rb
do_something %r| regexp|

% bundle exec rubocop --only Style/RegexpLiteral -a
(snip)

Offenses:

example.rb:1:14: C: [Corrected] Style/RegexpLiteral: Use // around regular expression.
do_something %r| regexp|
             ^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

% cat example.rb
do_something / regexp/

% ruby -c example.rb
example.rb:1: syntax error, unexpected end-of-input
```
@koic koic merged commit f2edbfa into rubocop:master Jun 17, 2021
@koic koic deleted the fix_a_false_positive_for_style_regexp_literal branch June 17, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant