various formulae: style fixes

[nandahkrishna]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

This PR is required for Homebrew/brew#11626. Some changes were made with brew style --fix, but others had to be done manually (where autocorrect wouldn't work properly).

Formulae where the changes weren't only style changes (but straightforward), I tried to build and test the formula locally. If we'd rather run CI here, I'll remove the CI-syntax-only label.

[carlocab]

I'd rather run CI on this. Not all of these changes are obviously NFC (no functional change).

Though maybe we can wait till the CI queue is less backed up? Unless this is urgent, anyway.

[nandahkrishna]

Not urgent and the CI queue being backed up was my main concern. I'll mark this as "do not merge" until we get a chance to run CI.

[carlocab]

Most of these are improvements but some of them are... not.

[nandahkrishna]

I'll rebase this once the Pillow-related PRs are merged. I'll also manually edit the ones that autocorrect spoilt, to the best of my ability 😅.

[nandahkrishna]

ARM:

Error: 4 failed steps!
brew install --build-from-source flow
brew install --build-from-source hashlink
brew install --build-from-source hyperkit
brew install --build-from-source infer

None have ARM bottles, so this is expected.

[MikeMcQuaid]

Formulae where the changes weren't only style changes (but straightforward), I tried to build and test the formula locally. If we'd rather run CI here, I'll remove the CI-syntax-only label.

I'm fine with using CI-syntax-only here, personally. I trust rubocop to do these autocorrects correctly.

[nandahkrishna]

ARM Big Sur:

Error: 4 failed steps!
brew install --build-from-source flow     # no ARM bottle
brew install --build-from-source hashlink # no ARM bottle
brew install --build-from-source hyperkit # no ARM bottle
brew install --build-from-source infer    # no ARM bottle

✅ All expected.

Intel Big Sur:

Error: 4 failed steps!
brew install --build-from-source hyperkit        # Known to be broken, no Big Sur bottle
brew test --retry --verbose hyperkit             # Same as above
brew install --build-from-source infer           # Need to check
brew install --verbose --build-bottle volatility # Python2 has no venv module, changes not related to failure (Homebrew/brew#10039)

🟡 Need to check infer.

Catalina:

Error: 4 failed steps!
brew test --verbose fn                           # Connection failure, looks like a false positive
brew install --build-from-source hyperkit        # See Big Sur comment
brew test --retry --verbose hyperkit             # Same as above
brew install --verbose --build-bottle volatility # See Big Sur comment

✅ 1 false positive, others expected.

Mojave:

Error: 4 failed steps!
brew audit molten-vk --online --git --skip-style # Network-related stable URL not reachable (re-checked, passed)
brew install --build-from-source hyperkit        # See Big Sur comment
brew test --retry --verbose hyperkit             # Same as above
brew install --verbose --build-bottle volatility # See Big Sur comment

✅ 1 network issue, others expected.

[nandahkrishna]

I'm unsure why infer failed to build on Intel Big Sur. It was built/tested only because of ocaml, which has a syntax-only change in a comment.

If we can ignore this failure, the PR should be good to merge, I think.

[carlocab]

Works for me. Thanks @nandahkrishna!

[nandahkrishna]

Rebased and merged. Thanks for the feedback everyone!