Fix dedenting Style/ClassAndModuleChildren #9886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
markburns
force-pushed
the
fix-indentation
branch
from
595b1b2
to
36101c9
Compare
markburns
changed the title
markburns
force-pushed
the
fix-indentation
branch
from
36101c9
to
5d30f1e
Compare
The Style/ClassAndModuleChildren style: compact had a bug that left the indentation intact, instead of dedenting it by the correct number of spaces after it autocorrected.
markburns
force-pushed
the
fix-indentation
branch
from
5d30f1e
to
a9a4350
Compare
|
Looks good! Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the auto-corrected indentation for Style/ClassAndModuleChildren with compact style .
This PR adds a failing spec for an issue with the Style/ClassAndModuleChildren cop not dedenting code correctly.I noticed this as I was wishing to add a new style, and found that the compact style does not remove whitespace correctly.I am curious if this is normal behaviour. I.e. do the indentation checks occur last, and so can be used for auto-correcting whitespace?I am trying to familiarise myself with the codebase to work out exactly how to implement this functionality in an idiomatic way. But if you have any pointers that would be helpful. I'd be happy to have a go at fixing this.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.