Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump carrierwave from 1.3.1 to 2.0.2 #3683

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps carrierwave from 1.3.1 to 2.0.2.

Release notes

Sourced from carrierwave's releases.

2.0.0.rc

Added

Changed

  • Use the storage given by storage configuration also for cache_storage unless explicitly specified(@​mshibuya 629afecb)
  • Improve Fog initialization(@​mshibuya #2395)
  • [BREAKING CHANGE] Multiple file uploader now keeps successful files on update, only discarding failed ones(@​mshibuya 7db9195d)
  • [BREAKING CHANGE] #remote_#{column}_urls= was changed to preserve precedent updates(@​mshibuya 8f18a95b)
  • #serializable_hash now returns string for version keys(@​schovi #2246)
  • Use the MimeMagic gem to inspect file headers for the mime type. This allows for mitigation of CVE-2016-3714, in combination with a content_type_whitelist(@​locriani #1934)
  • Replace mime-types dependency with mini_mime to save memory(@​bradleypriest #2292)
  • Delegate MiniMagick processing to ImageProcessing gem(@​janko #2298)
  • Handle ActiveRecord transaction correctly, not storing or removing files on rollback(@​skosh #2209)

Deprecated

  • fog_provider configuration was deprecated and has no effect, just adding fog providers to Gemfile will load them(@​mshibuya ca201ee2)
  • CarrierWave::Uploader::Base#sanitized_file was deprecated, use #file instead(@​mshibuya 28190e99)

Removed

Fixed

Changelog

Sourced from carrierwave's changelog.

2.0.2 - 2019-09-28

Fixed

2.0.1 - 2019-08-31

Fixed

2.0.0 - 2019-08-18

No changes.

2.0.0.rc - 2019-06-23

Added

Changed

  • Use the storage given by storage configuration also for cache_storage unless explicitly specified(@​mshibuya 629afecb)
  • Improve Fog initialization(@​mshibuya #2395)
  • [BREAKING CHANGE] Multiple file uploader now keeps successful files on update, only discarding failed ones(@​mshibuya 7db9195d)
  • [BREAKING CHANGE] #remote_#{column}_urls= was changed to preserve precedent updates(@​mshibuya 8f18a95b)
  • #serializable_hash now returns string for version keys(@​schovi #2246)
  • Use the MimeMagic gem to inspect file headers for the mime type. This allows for mitigation of CVE-2016-3714, in combination with a content_type_whitelist(@​locriani #1934)
  • Replace mime-types dependency with mini_mime to save memory(@​bradleypriest #2292)
  • Delegate MiniMagick processing to ImageProcessing gem(@​janko #2298)
  • Handle ActiveRecord transaction correctly, not storing or removing files on rollback(@​skosh #2209)

Deprecated

  • fog_provider configuration was deprecated and has no effect, just adding fog providers to Gemfile will load them(@​mshibuya ca201ee2)
  • CarrierWave::Uploader::Base#sanitized_file was deprecated, use #file instead(@​mshibuya 28190e99)

Removed

Fixed

... (truncated)
Commits
  • f81bb4d Version 2.0.2
  • c4b6d91 Cloud not make JRuby build pass on Xenial, reverting back to Trusty
  • b2bd43b Merge pull request #2419 from fukayatsu/fix-remote-file-error
  • 5494bf4 Fix build issues with PostgreSQL and ImageMagick
  • 449397a Fix remote_x_url= raise NoMethodError
  • e1c3eea Version 2.0.1
  • 22e8005 Fix passing empty string to #image_cache= causes existing ones deleted. Fixes...
  • 96a0b03 Version 2.0.0 🌟
  • 0e8742b Version 2.0.0.rc
  • 536c0d3 Fix a failing spec in fc65d164
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the Dependencies Pull requests that update a dependency file label Oct 15, 2019
@trangmei
Copy link
Contributor

Carrierwave 2.0 upgrade comes with changes that break our image uploader.

It was reported after the initial 1.3.1 -> 2.0 upgrade that all course duplication errors out.

This PR was put in to prevent 404 error encountered in our image uploader: #3652

It was later reported that duplicated courses do not have logos:
#3677

Carrierwave was temporarily downgraded while further investigation can be done.

@dependabot-preview
Copy link
Contributor Author

Superseded by #3751.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/carrierwave-2.0.2 branch February 17, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant