Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mime-types gem with mini_mime #2292

Merged
merged 4 commits into from Mar 30, 2019

Conversation

bradleypriest
Copy link
Contributor

@bradleypriest bradleypriest commented Mar 11, 2018

Replaces the MimeTypes gem with MiniMime.

Similar to mikel/mail#1059 and teamcapybara/capybara#1884, this switches out the Mime Types gem with MiniMime to save memory.

EDIT:
There seems to be some requirements around the integration between carrierwave and fog going on here.

I see a couple of options:

  1. We more explicitly call out that if they're using fog, they'll need to include the mime-types gem.
  2. We try and convince fog to move across to mini_mime as well.
  3. We add a mime-helper module that defines the three methods we use the mime gems for which can delegate to whichever library is included in the Gemfile.
  4. We don't support mini_mime

With the incredibly popular mail and capybara gems moving to mini_mime, it'd be nice to switch carrierwave across too (or at least provide the option)

@bradleypriest
Copy link
Contributor Author

Any feedback from the team here?

@bradleypriest
Copy link
Contributor Author

@mshibuya any thoughts either way on this change?

@mshibuya mshibuya added this to the Release v2.0.0 milestone Jul 17, 2018
@bradleypriest
Copy link
Contributor Author

This PR has been open a year now, I appreciate it's set up for the 2.0 release of the gem, which is an absolutely herculean task.

However for my own mental wellbeing (I can't deal with a PR being open this long), I'm going to close it now.

Anyone is welcome to this code at any time, whether it's by reopening this PR, or recreating a new one.

Thanks for the hard work.

@mshibuya mshibuya reopened this Mar 30, 2019
@mshibuya mshibuya merged commit 664e99e into carrierwaveuploader:master Mar 30, 2019
@mshibuya
Copy link
Member

Sorry for being late, we appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants