Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote_x_url= raise undefined method `[]' for nil:NilClass (NoMethodError) #2419

Merged
merged 1 commit into from Sep 10, 2019
Merged

Fix remote_x_url= raise undefined method `[]' for nil:NilClass (NoMethodError) #2419

merged 1 commit into from Sep 10, 2019

Conversation

fukayatsu
Copy link
Contributor

@fukayatsu fukayatsu commented Sep 10, 2019

Fix remote_x_url= when the response header includes content-disposition: inline;filename=""

Please see #2411 (comment) for detail.

Maybe related to #2415 also.

when the response header includes `content-disposition: inline;filename=""`
@fukayatsu
Copy link
Contributor Author

fukayatsu commented Sep 10, 2019

I see Travis CI is falling but it seems not related to this PR.
I'll rebase this branch if CI fixed :)

I could pass remote_file_spec.rb locally.

$ bundle exec rspec spec/downloader/remote_file_spec.rb
.......

Finished in 0.00647 seconds (files took 0.70994 seconds to load)
7 examples, 0 failures

@mshibuya mshibuya merged commit b2bd43b into carrierwaveuploader:master Sep 10, 2019
@mshibuya
Copy link
Member

Awesome, thanks!
I'll work on the CI later.

@fukayatsu fukayatsu deleted the fix-remote-file-error branch September 10, 2019 06:34
@fukayatsu
Copy link
Contributor Author

Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants