New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return unexpected false for content type when file is deleted #2384

Merged

mshibuya merged 1 commit into carrierwaveuploader:master from longkt90:master

Apr 30, 2019

Contributor

longkt90 commented Mar 24, 2019

Background:

it is weird when calling file.content_type return false if file is deleted
I would expecting a string (or maybe nil) for file.content_type


          Do not return unexpected false for content type when file is deleted

aefc577

mshibuya merged commit 65fa873 into carrierwaveuploader:master

Member

mshibuya commented Apr 30, 2019

Thanks👍

mshibuya added a commit that referenced this pull request


          Make #2384 work with Ruby 2.2

0195c8c

alecslupu mentioned this pull request

Upgrade carrierwave to version 2.1 decidim/decidim#7213

Merged

12 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment