Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #serializable_hash to returns string keys for versions #2246

Merged
merged 1 commit into from Apr 30, 2019
Merged

Fix #serializable_hash to returns string keys for versions #2246

merged 1 commit into from Apr 30, 2019

Conversation

schovi
Copy link
Contributor

@schovi schovi commented Nov 3, 2017 •
edited

> uploader.as_json

Before:

{
  "url" => "/uploads/81445456.jpg", 
  :thumb => {
    "url" => "/uploads/thumb_81445456.jpg"
  }
}

After:

{
  "url" => "/uploads/81445456.jpg", 
  "thumb" => {
    "url" => "/uploads/thumb_81445456.jpg"
  }
}

@mshibuya
Copy link
Member

mshibuya commented Jan 2, 2018

Test needed!

@mshibuya mshibuya merged commit 2aaaedf into carrierwaveuploader:master Apr 30, 2019
@mshibuya
Copy link
Member

I'll write a spec, thanks.

mshibuya added a commit that referenced this pull request Apr 30, 2019
@mshibuya
Add spec for #2246
588a93b
@alecslupu alecslupu mentioned this pull request Jan 24, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schovi @mshibuya