Update add_options for flake8 6.0 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
maltevesper
approved these changes
Nov 29, 2022
This was referenced Nov 29, 2022
anton44eg
approved these changes
Dec 1, 2022
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/python-stdnum
that referenced
this pull request
Dec 1, 2022
PyCQA/flake8#1760 Plugin flake8-quotes is currently incompatible with flake8 v6. Work around by pinning flake8 until the flake8-quotes issue is fixed: zheller/flake8-quotes#111 is merged.
kalikiana
added a commit
to os-autoinst/openqa_review
that referenced
this pull request
Dec 2, 2022
kalikiana
added a commit
to os-autoinst/openqa_review
that referenced
this pull request
Dec 2, 2022
kalikiana
added a commit
to os-autoinst/openqa_review
that referenced
this pull request
Dec 2, 2022
kalikiana
added a commit
to os-autoinst/openqa_review
that referenced
this pull request
Dec 2, 2022
ScottMcCormack
referenced
this pull request
in arthurdejong/webchat
Dec 4, 2022
The new 6.0.0 contains a number of backwards incompatible changes for which plugins need to be updated and configuration needs to be updated. Sadly the maintainer no longer accepts contributions or discussion See PyCQA/flake8#1760
dopry
approved these changes
Dec 5, 2022
|
When is this expected to be released? |
DanielSchiavini
approved these changes
Dec 9, 2022
JoeHitchen
approved these changes
Dec 9, 2022
discosultan
approved these changes
Dec 9, 2022
The number of reviewers seems to be too low ATM, it might need more approvals? |
zheller
approved these changes
Dec 9, 2022
|
ty for the merge |
|
@zheller would you mind making a new release please 🙏 |
|
@zheller make a release |
|
@evrial demanding things from an OSS contributor like a petulant child is uncalled for. |
|
@dopry fair enough. what options do we have? fork and call flake8-quotes2 ? |
|
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/python-stdnum
that referenced
this pull request
Jun 18, 2023
PyCQA/flake8#1760 Plugin flake8-quotes compatible with flake8 6.0 starting with 3.3.2: zheller/flake8-quotes#111 is merged.
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/python-stdnum
that referenced
this pull request
Jun 18, 2023
PyCQA/flake8#1760 Plugin flake8-quotes is now compatible with flake8 6.0, starting with release 3.3.2: zheller/flake8-quotes#111 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to make
flake8-quoteswork withflake86 for me, i.e. tests pass and projects lint without crashes. For detailshttps://flake8.pycqa.org/en/latest/release-notes/6.0.0.html#backwards-incompatible-changes
Fixes #110