Run CI for Python 3.6 on Ubuntu 20.04 #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalikiana
force-pushed
the
ci_mocker_mock_mock
branch
2 times, most recently
from
6a50b8b
to
0c6fd99
Compare
kalikiana
changed the title
perlpunk
approved these changes
Dec 2, 2022
r-richardson
approved these changes
Dec 2, 2022
okurz
requested changes
Dec 2, 2022
There was a problem hiding this comment.
CI checks fail in https://github.com/os-autoinst/openqa_review/actions/runs/3602936327/jobs/6070510255#step:5:38 with
flake8 run-test: commands[0] | flake8
Traceback (most recent call last):
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/bin/flake8", line 8, in <module>
sys.exit(main())
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8/main/cli.py", line 23, in main
app.run(argv)
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8/main/application.py", line 198, in run
self._run(argv)
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8/main/application.py", line 186, in _run
self.initialize(argv)
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8/main/application.py", line 165, in initialize
self.plugins, self.options = parse_args(argv)
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8/options/parse_args.py", line 51, in parse_args
option_manager.register_plugins(plugins)
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8/options/manager.py", line 259, in register_plugins
add_options(self)
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8_quotes/__init__.py", line 109, in add_options
cls._register_opt(parser, '--quotes', action='store',
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8_quotes/__init__.py", line 99, in _register_opt
parser.add_option(*args, **kwargs)
File "/home/runner/work/openqa_review/openqa_review/.tox/flake8/lib/python3.10/site-packages/flake8/options/manager.py", line 281, in add_option
self._current_group.add_argument(*option_args, **option_kwargs)
File "/opt/hostedtoolcache/Python/3.10.8/x64/lib/python3.10/argparse.py", line 1428, in add_argument
raise ValueError('%r is not callable' % (type_func,))
ValueError: 'choice' is not callable
ERROR: InvocationError for command /home/runner/work/openqa_review/openqa_review/.tox/flake8/bin/flake8 (exited with code 1)
Is this related?
EDIT: Oh and please make sure the git commit message subject line states the "Why", not the "What"
kalikiana
force-pushed
the
ci_mocker_mock_mock
branch
from
0c6fd99
to
c561797
Compare
kalikiana
changed the title
kalikiana
changed the title
kalikiana
force-pushed
the
ci_mocker_mock_mock
branch
2 times, most recently
from
350113e
to
24ca118
Compare
The now latest Ubuntu no longer ships with 3.6.
kalikiana
force-pushed
the
ci_mocker_mock_mock
branch
from
24ca118
to
2dc4dc4
Compare
mimi1vx
approved these changes
Dec 2, 2022
okurz
approved these changes
Dec 3, 2022
perlpunk
reviewed
Dec 16, 2022
| @@ -24,7 +26,7 @@ commands = black --check --diff --fast . | |||
|
|
|||
| [testenv:flake8] | |||
| deps = | |||
| flake8 | |||
| flake8<6.0.0 # TODO remove pinned version once https://github.com/zheller/flake8-quotes/pull/111 is merged. | |||
There was a problem hiding this comment.
Note: zheller/flake8-quotes#111 was merged, but no release yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The now latest Ubuntu no longer ships with 3.6.