Fix invocation of shapeworks commands #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on zheller/flake8-quotes#111 to pass tests |
|
We could temporarily add 'flake8<6' in the tox lint dependencies (in this block https://github.com/girder/shapeworks-cloud/blob/master/tox.ini#L11) |
|
Thanks, changed in 2553711 |
annehaley
added a commit
that referenced
this pull request
Nov 30, 2022
* Fix invocation of shapeworks commands * Lint fix * Pin flake8
annehaley
added a commit
that referenced
this pull request
Dec 2, 2022
* Implement PCA slider * Show other values in PCA View * Change rendered shape when switching between analysis tab and other tabs * Preserve camera position in analysis tab view * Fix invocation of shapeworks commands (#216) * Fix invocation of shapeworks commands * Lint fix * Pin flake8 * Sort modes in dropdown * Fix switching between multiple data renderers and single analysis renderer * Fix application of camera deltas * Reset analysis when project is deselected * Always show analysis files at 100% opacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swcc switched to relative downloads only (ignoring "../" in path values), the invocation of shapeworks commands was broken. To compensate, before invoking the shapeworks command, the project file is edited to remove instances of "../".
Additionally, #214 made a change to the dockerfile that doesn't actually work. I thought I had found a static url that gave us the download we needed, but that tarball wasn't built, and the invocation of the commands was broken for that reason as well. This PR undoes that change.