Bump github.com/gobuffalo/pop/v6 from 6.0.6 to 6.0.8

[dependabot]

Bumps github.com/gobuffalo/pop/v6 from 6.0.6 to 6.0.8.

Release notes

Sourced from github.com/gobuffalo/pop/v6's releases.

v6.0.8

What's Changed

• upgraded module dependencies by @​sio4 in gobuffalo/pop#789

Full Changelog: gobuffalo/pop@v6.0.7...v6.0.8

v6.0.7

What's Changed

• fix: make disableEager not trigger the race detector by @​zepatrik in gobuffalo/pop#746
• log SQL for association query by @​Schparky in gobuffalo/pop#686
• Make slices.Map UnmarshalJSON a pointer receiver by @​naemono in gobuffalo/pop#655
• added test cases for slices.Map (for #655) by @​sio4 in gobuffalo/pop#769
• cleanup testing stuff by @​sio4 in gobuffalo/pop#767
• fixed url handling with reserved characters (fixes #402) by @​sio4 in gobuffalo/pop#774
• catch panic within transaction to complete rollback (fixes #748) by @​sio4 in gobuffalo/pop#775
• fixed replacing bug on WHERE IN statement (fixes #778) by @​sio4 in gobuffalo/pop#779
• fix missing Where in eager creation method by @​sio4 in gobuffalo/pop#780
• removed mysqldump option --column-statistics to make it compatible with 5.7 by @​sio4 in gobuffalo/pop#776
• fix Connection.Close() to reset the store by @​sio4 in gobuffalo/pop#781
• made default logger to print output to stderr instead of stdout by @​sio4 in gobuffalo/pop#782
• made the 'version' column primary key to fix #659 by @​sio4 in gobuffalo/pop#783
• fixed delete + where in issue on mysql (#699) by @​sio4 in gobuffalo/pop#784
• fixed concurrent map write issue on ConnectionDetails.Options (#577) by @​sio4 in gobuffalo/pop#785
• prevent empty query to be executed by @​sio4 in gobuffalo/pop#786
• updated README, SHOULDERS, and module dependencies by @​sio4 in gobuffalo/pop#787

New Contributors

• @​Schparky made their first contribution in gobuffalo/pop#686

Full Changelog: gobuffalo/pop@v6.0.6...v6.0.7

Commits

• 482c695 upgraded module dependencies
• 8919b88 added or replaced stale issue closer with standard version
• 5a179e7 updated README, SHOULDERS, and module dependencies
• 9efb85f prevent empty query to be executed
• d71c504 fixed concurrent map write issue on ConnectionDetails.Options (#577)
• 902a7d1 fixed delete + where in issue on mysql (#699)
• 9a26827 made 'version' colume as primary key to fix #659
• df9e1b2 made default logger to print output to stderr instead of stdout
• b0c857d fix Connection.Close() to reset the store
• 98751a9 removed mysqldump option --column-statistics to make it compatible
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[ghost]

@dependabot rebase

[scottmries]

@dependabot rebase

[reggieriser]

@dependabot rebase

[reggieriser]

It looks like our failing tests are due to this change in Pop 6.0.7. In a nutshell, in some tests, we were calling the Close method multiple times for a connection in a couple of cases and that caused a panic since the referenced Pop PR now sets the connection's Store to nil on a close. So, the second time calling Close, Pop was attempting to use the Store when it was already nil, thus leading to the panic.

I've added changes that hopefully prevent our second calls to Close.

[reggieriser]

Since I don't know what may have happened leading up this Cleanup call, I didn't see a way to prevent the panic here other than introspecting the Store to see if it was nil. If it's nil, I'm assuming the connection has already been closed.

[reggieriser]

I've reworked this to handle it in a different way that involves changes to the offending test and closing a connection that leads to a panic. Hopefully a little cleaner.

[reggieriser]

The problem here seemed to be that we had cases where the low and high privileged connections were the same. If that's the case, closing both would lead to two Close calls on the same connection and therefore a panic in Pop 6.0.8.

[ahobson]

I'm pretty sure the problem is that per test transactions cleanup themselves via a Cleanup callback. So I think the right fix is something like

	// Remove the package DB if this isn't a per test transaction
	if !suite.usePerTestTransaction {
		if err := dropDB(suite.pgConn, (*suite.lowPrivConnDetails).Database); err != nil {
			log.Panic(err)
		}
		// suite.pgConn will be closed by a suite.T().Cleanup function
		// for per test transaction tests, so we only need to clean it
		// up here for non transaction tests
		err := suite.pgConn.Close()
		if err != nil {
			log.Panic(err)
		}
	}

[reggieriser]

I'm confused about the above change/comment. Isn't the Cleanup function cleaning up a different connection (popConn that's created on a DB() call?) vs. the pgConn here that's created on a NewPopTestSuite call? Or are those actually the same connection?

[ahobson]

This is SUCH GOOD WORK. Thank you