Make slices.Map UnmarshalJSON a pointer receiver #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test please? Thank you! |
|
I have the same issue, value will be nil when slices.map used as a table's column type |
sio4
force-pushed
the
map-unmarshal-pointer-receiver
branch
from
4a801ab
to
834c3c3
Compare
sio4
approved these changes
Sep 18, 2022
| @@ -47,17 +47,17 @@ func (m Map) Value() (driver.Value, error) { | |||
|
|
|||
| // UnmarshalJSON will unmarshall JSON value into | |||
| // the map representation of this value. | |||
| func (m Map) UnmarshalJSON(b []byte) error { | |||
| func (m *Map) UnmarshalJSON(b []byte) error { | |||
There was a problem hiding this comment.
It should be! Thanks for correcting the code!
|
I will cover the test cases myself. Thanks! |
sio4
added a commit
that referenced
this pull request
Sep 18, 2022
sio4
added a commit
that referenced
this pull request
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654