Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Connection.Close() to reset the store #781

Merged
merged 1 commit into from Sep 24, 2022
Merged

fix Connection.Close() to reset the store #781

merged 1 commit into from Sep 24, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Sep 24, 2022

As reported in #510, the Connection.Close() just closes the connection to the database but did not update the status of Connection so it could not be reused with Open().

This PR makes the method to reset Store so Open() can understand the status of the Connection. Also, added a test case for this issue.

fixes #510

@sio4 sio4 added the bug Something isn't working label Sep 24, 2022
@sio4 sio4 added this to the v6.0.7 milestone Sep 24, 2022
@sio4 sio4 self-assigned this Sep 24, 2022
@sio4 sio4 mentioned this pull request Sep 24, 2022
Closed
30 tasks
@sio4 sio4 merged commit b0c857d into main Sep 24, 2022
@sio4 sio4 deleted the fix-connection-closing branch September 24, 2022 06:38
@reggieriser reggieriser mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sio4 sio4

Labels
bug Something isn't working
Projects
None yet
Milestone
v6.0.7
Development

Successfully merging this pull request may close these issues.

Reconnect DB after closing.
1 participant
@sio4