Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed url handling with reserved characters (fixes #402) #774

Merged
merged 2 commits into from Sep 24, 2022
Merged

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Sep 22, 2022

Indeed, #402 is a valid and important issue that users can confuse.

  • The cd.URL is a kind of raw value that should be able to directly interpreted by the underlying database engine, so using a plain version (without URL encoding) of the password with reserved characters is not a valid usage. However, when if the user provided a correctly encoded URL, we should be able to parse and store the value in CD structure.
  • When we create URLs for database connection, we should be able to generate a correct URL with the parsed CD values, and it should be a valid URL that can be interpreted by the database engine.
  • MySQL is an exception since their connection URL is not a standard format.

fixes #402

@sio4 sio4 added the bug Something isn't working label Sep 22, 2022
@sio4 sio4 added this to the v6.0.7 milestone Sep 22, 2022
@sio4 sio4 self-assigned this Sep 22, 2022
@sio4 sio4 requested review from a team September 22, 2022 06:32
@sio4 sio4 mentioned this pull request Sep 22, 2022
30 tasks
Copy link
Member Author

@sio4 sio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments for future reference

.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
connection_details_test.go Show resolved Hide resolved
dialect_cockroach.go Show resolved Hide resolved
@sio4 sio4 merged commit 2cbff73 into main Sep 24, 2022
@sio4 sio4 deleted the fix-url-handling branch September 24, 2022 05:29
@sio4 sio4 added the s: fixed was fixed or solution offered label Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s: fixed was fixed or solution offered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error parsing database password in database.yml
1 participant