Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI/React: Add interactions to cli template #17345

Merged
merged 2 commits into from Feb 4, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 26, 2022

Issue: #16722

What I did

cli.template.propostal.mov

How to test

access it here (it won't have the interactions panel by default though)

or build cli locally and run repro to select react as a framework

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 26, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit c6a786e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf added the cli label Jan 26, 2022
@yannbf yannbf force-pushed the feat/add-interactions-to-cli-template branch 2 times, most recently from 800d1f4 to 7bc2cfc Compare January 26, 2022 20:19
@yannbf yannbf force-pushed the feat/add-interactions-to-cli-template branch from fc1c138 to ac853da Compare February 3, 2022 15:54
@yannbf yannbf changed the title WIP: add interactions to cli template React: add interactions to cli template Feb 3, 2022
@yannbf yannbf force-pushed the feat/add-interactions-to-cli-template branch from ac853da to 5d72d64 Compare February 4, 2022 08:37
@shilman shilman changed the title React: add interactions to cli template CLI/React: Add interactions to cli template Feb 4, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @yannbf !!! 🚀

@shilman shilman merged commit 10657ba into next Feb 4, 2022
@shilman shilman deleted the feat/add-interactions-to-cli-template branch February 4, 2022 11:46
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 4, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 12, 2022
shilman added a commit that referenced this pull request Feb 12, 2022
…li-template

CLI/React: Add interactions to cli template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: interactions cli feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants