New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI/React: Add interactions to cli template #17345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit c6a786e. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
force-pushed
the
feat/add-interactions-to-cli-template
branch
2 times, most recently
from
January 26, 2022 20:19
800d1f4
to
7bc2cfc
Compare
yannbf
force-pushed
the
feat/add-interactions-to-cli-template
branch
from
February 3, 2022 15:54
fc1c138
to
ac853da
Compare
yannbf
changed the title
WIP: add interactions to cli template
React: add interactions to cli template
Feb 3, 2022
yannbf
force-pushed
the
feat/add-interactions-to-cli-template
branch
from
February 4, 2022 08:37
ac853da
to
5d72d64
Compare
shilman
changed the title
React: add interactions to cli template
CLI/React: Add interactions to cli template
Feb 4, 2022
shilman
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition @yannbf !!! 🚀
yannbf
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Feb 4, 2022
8 tasks
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Feb 12, 2022
shilman
added a commit
that referenced
this pull request
Feb 12, 2022
…li-template CLI/React: Add interactions to cli template
This was referenced Apr 16, 2022
3 tasks
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addon: interactions
cli
feature request
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
react
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16722
What I did
cli.template.propostal.mov
How to test
access it here (it won't have the interactions panel by default though)
or build cli locally and run
repro
to select react as a frameworkIf your answer is yes to any of these, please make sure to include it in your PR.