New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI/Svelte: add interactions to cli template #17993
CLI/Svelte: add interactions to cli template #17993
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 80a96de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Thanks for this contribution @italoteix !! Unfortunately this is broken with the latest release of
It works correctly with |
Hey @j3rem1e do you happen to have any idea why an error like that would happen in the svelte project? It does work on other projects i.e. React |
Honestly.. I don't know ^^ However, I reproduce this issue easly in addon-svelte-csf by upgrading to @storybook/testing-library 0.0.10. And a fix is to add this rule to the configuration of webpack :
|
This is good now, the problem was circumvented in a new release of |
@italoteix if you could message me (same username) on our Discord Server I'd appreciate it as I would like to follow up on this pull request and the other one you created that includes the interactions for Preact. Looking forward to your message. Hope you have a great weekend! Stay safe |
Issue: #16722
What I did
Similar to PR #17345. Added interactions to Svelte cli template.
How to test
Build cli locally and run repro to select Svelte as a framework
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.